Skip to content

feat: enable dry-run mode for HBase to Cloud Bigtable replication #3532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vermas2012 merged 13 commits into from
Mar 16, 2022
Merged

feat: enable dry-run mode for HBase to Cloud Bigtable replication #3532

vermas2012 merged 13 commits into from
Mar 16, 2022

Conversation

@vermas2012
Copy link
Member

@vermas2012 vermas2012 commented Feb 28, 2022 •
edited
Loading

Pending AIs:

  • Update the readme.md after the readme PR is merged.

@vermas2012 vermas2012 requested a review from a team as a code owner February 28, 2022 22:22
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable-hbase API. label Feb 28, 2022
@vermas2012 vermas2012 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 3, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 3, 2022
jhambleton
jhambleton approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@jhambleton jhambleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a few nits, overall lgtm. dry-run mode is a great addition!

kolea2
kolea2 reviewed Mar 7, 2022
View reviewed changes
igorbernstein2
igorbernstein2 reviewed Mar 15, 2022
View reviewed changes
...-core/src/main/java/com/google/cloud/bigtable/hbase/replication/CloudBigtableReplicator.java
.build());

// Create a connection to Cloud Bigtable.
Configuration configurationCopy = new Configuration(conf);
Copy link
Collaborator

@igorbernstein2 igorbernstein2 Mar 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a Precondition that conf is not an instance of BigtableExtendedConfiguration

Copy link
Member Author

@vermas2012 vermas2012 Mar 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the problem if its an instance of BigtableExtendedConfiguration?

@vermas2012 vermas2012 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 16, 2022
@vermas2012 vermas2012 merged commit 164738b into googleapis:main Mar 16, 2022
@vermas2012 vermas2012 deleted the dry-run-2 branch March 16, 2022 18:19
@release-please release-please bot mentioned this pull request Mar 16, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 4, 2022
@release-please
chore(main): release 2.1.0 (#3524)
b61d3fd 
🤖 I have created a release *beep* *boop*
---


## [2.1.0](v2.0.0...v2.1.0) (2022-04-01)


### Features

* [hase-cbt-replication]Add a metrics for hbase<>bigtable timestamp overflow ([#3540](#3540)) ([9c73318](9c73318))
* Adding a detailed readme for HBase replication support. ([#3527](#3527)) ([b406ac5](b406ac5))
* enable dry-run mode for HBase to Cloud Bigtable replication ([#3532](#3532)) ([164738b](164738b))
* Enable HBase to Cloud Bigtable replication  ([#3510](#3510)) ([68d4a01](68d4a01))
* flag a put in future timestamp and record a metrics ([#3534](#3534)) ([7dd7653](7dd7653))
* remove base repl endpoint from hbase 2.x ([#3539](#3539)) ([f748c70](f748c70))


### Bug Fixes

* [hbase-cbt-replication] make hbase2.x endpoint context private ([#3559](#3559)) ([5ec3b18](5ec3b18))
* consistent behavior of customwalentry filter across hbase1.x and hbase2.x ([#3562](#3562)) ([f70b0cb](f70b0cb))
* license and notice files for all the shaded artifacts ([#3565](#3565)) ([86a5643](86a5643))
* minor documentation update ([#3572](#3572)) ([68db6c2](68db6c2))


### Documentation

* fix typos in README and add --region option ([#3520](#3520)) ([c189d46](c189d46))


### Dependencies

* update dependency ch.qos.logback:logback-classic to v1.2.11 ([#3538](#3538)) ([92e8b63](92e8b63))
* update dependency com.google.cloud:google-cloud-bigtable-emulator to v0.142.3 ([#3528](#3528)) ([33a8eba](33a8eba))
* update dependency com.google.cloud:google-cloud-bigtable-emulator to v0.143.0 ([#3543](#3543)) ([2d57f14](2d57f14))
* update dependency net.bytebuddy:byte-buddy to v1.12.8 ([#3502](#3502)) ([77ae2f1](77ae2f1))
* update jmh.version to v1.35 ([#3561](#3561)) ([188738d](188738d))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

+2 more reviewers

@kolea2 kolea2 kolea2 left review comments

@jhambleton jhambleton jhambleton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/java-bigtable-hbase API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vermas2012 @jhambleton @igorbernstein2 @kolea2