Skip to content

Conversation

@vermas2012
Copy link
Member

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@vermas2012 vermas2012 requested a review from a team as a code owner February 28, 2022 20:19
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable-hbase API. label Feb 28, 2022
@vermas2012
Copy link
Member Author

@jhambleton PTAL. I had to re-create another PR due to branch issues, I have addressed all the comments except one. #3525 (comment)

@vermas2012
Copy link
Member Author

Updated the PR with some details on authentication.

@jhambleton should we create a top level section on authentication along with configuration?

Copy link
Contributor

@jhambleton jhambleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for incorporating other changes from pr#3525 here! all looks good with minor nit around timestamp incompatibility.

Copy link
Contributor

@jhambleton jhambleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates, lgtm

@vermas2012 vermas2012 added the automerge Merge the pull request once unit tests and other checks pass. label Mar 1, 2022
@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 1, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 1, 2022
@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 1, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 1, 2022
@mutianf mutianf added the owlbot:ignore instruct owl-bot to ignore a PR label Mar 1, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit b406ac5 into googleapis:main Mar 1, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 1, 2022
@vermas2012 vermas2012 deleted the readme branch March 1, 2022 23:12
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 4, 2022
🤖 I have created a release *beep* *boop*
---


## [2.1.0](v2.0.0...v2.1.0) (2022-04-01)


### Features

* [hase-cbt-replication]Add a metrics for hbase<>bigtable timestamp overflow ([#3540](#3540)) ([9c73318](9c73318))
* Adding a detailed readme for HBase replication support. ([#3527](#3527)) ([b406ac5](b406ac5))
* enable dry-run mode for HBase to Cloud Bigtable replication ([#3532](#3532)) ([164738b](164738b))
* Enable HBase to Cloud Bigtable replication  ([#3510](#3510)) ([68d4a01](68d4a01))
* flag a put in future timestamp and record a metrics ([#3534](#3534)) ([7dd7653](7dd7653))
* remove base repl endpoint from hbase 2.x ([#3539](#3539)) ([f748c70](f748c70))


### Bug Fixes

* [hbase-cbt-replication] make hbase2.x endpoint context private ([#3559](#3559)) ([5ec3b18](5ec3b18))
* consistent behavior of customwalentry filter across hbase1.x and hbase2.x ([#3562](#3562)) ([f70b0cb](f70b0cb))
* license and notice files for all the shaded artifacts ([#3565](#3565)) ([86a5643](86a5643))
* minor documentation update ([#3572](#3572)) ([68db6c2](68db6c2))


### Documentation

* fix typos in README and add --region option ([#3520](#3520)) ([c189d46](c189d46))


### Dependencies

* update dependency ch.qos.logback:logback-classic to v1.2.11 ([#3538](#3538)) ([92e8b63](92e8b63))
* update dependency com.google.cloud:google-cloud-bigtable-emulator to v0.142.3 ([#3528](#3528)) ([33a8eba](33a8eba))
* update dependency com.google.cloud:google-cloud-bigtable-emulator to v0.143.0 ([#3543](#3543)) ([2d57f14](2d57f14))
* update dependency net.bytebuddy:byte-buddy to v1.12.8 ([#3502](#3502)) ([77ae2f1](77ae2f1))
* update jmh.version to v1.35 ([#3561](#3561)) ([188738d](188738d))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable-hbase API. owlbot:ignore instruct owl-bot to ignore a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants