Skip to content

Conversation

@mutianf
Copy link
Contributor

@mutianf mutianf commented Sep 23, 2021

Now that auth library bundles pre-emptive refresh, RefreshingOAuth2CredentialsInterceptor can be removed. Also, remove retry on UNAUTHENTICATED

@mutianf mutianf requested a review from a team as a code owner September 23, 2021 17:27
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable-hbase API. label Sep 23, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2021
@mutianf mutianf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 23, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 23, 2021
Copy link
Collaborator

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but please expand your imports

@igorbernstein2 igorbernstein2 changed the title chore: remove refreshing credentials interceptor feat: migrate to google-auth-library for pre-emptive oauth refresh Sep 24, 2021
@mutianf mutianf added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 24, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 24, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8031a29 into googleapis:bigtable-1.x Sep 24, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 24, 2021
@mutianf mutianf deleted the auth branch September 24, 2021 18:06
mutianf added a commit to mutianf/java-bigtable-hbase that referenced this pull request Sep 20, 2022
…oogleapis#3228)

Now that auth library bundles [pre-emptive refresh](googleapis/google-auth-library-java#646), RefreshingOAuth2CredentialsInterceptor can be removed. Also, remove retry on UNAUTHENTICATED
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable-hbase API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants