Skip to content

Conversation

@billyjacobson
Copy link
Contributor

…3203)

  • fix: adding validation for snapshot name

  • add messages to failures in test

  • Check empty project id and snapshot directory

(cherry picked from commit fa9991a)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

…oogleapis#3203)

* fix: adding validation for snapshot name

* add messages to failures in test

* Check empty project id and snapshot directory

(cherry picked from commit fa9991a)
@billyjacobson billyjacobson requested a review from a team as a code owner September 22, 2021 18:58
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable-hbase API. label Sep 22, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 22, 2021
@eaball35 eaball35 added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 23, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 23, 2021
@kolea2 kolea2 merged commit 38925e8 into googleapis:bigtable-1.x Sep 23, 2021
mutianf pushed a commit to mutianf/java-bigtable-hbase that referenced this pull request Sep 20, 2022
…oogleapis#3203) (googleapis#3226)

* fix: adding validation for snapshot name

* add messages to failures in test

* Check empty project id and snapshot directory

(cherry picked from commit fa9991a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable-hbase API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants