impl(storage): move from tokio::sync::SetOnce to std::sync::OnceLock#4198
Merged
alvarowolfx merged 1 commit intogoogleapis:mainfrom Jan 9, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4198 +/- ##
==========================================
- Coverage 94.78% 94.76% -0.02%
==========================================
Files 187 187
Lines 7110 7110
==========================================
- Hits 6739 6738 -1
- Misses 371 372 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
requested changes
Jan 9, 2026
Collaborator
coryan
left a comment
There was a problem hiding this comment.
I looked and the critical sections are short, they do not lock over a .await call. LGTM.
ldetmer
pushed a commit
to ldetmer/google-cloud-rust
that referenced
this pull request
Jan 9, 2026
…oogleapis#4198) tokio::sync::SetOnce required newer version of tokio. Move to `std` lib alternative. Towards googleapis#3645 and fix minimal-version check on googleapis#4185
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tokio::sync::SetOnce required newer version of tokio. Move to
stdlib alternative.Towards #3645 and fix minimal-version check on #4185