Skip to content

feat(storage): mark signed url stable#4185

Merged
alvarowolfx merged 9 commits intogoogleapis:mainfrom
alvarowolfx:feat-stable-signed-url
Jan 9, 2026
Merged

feat(storage): mark signed url stable#4185
alvarowolfx merged 9 commits intogoogleapis:mainfrom
alvarowolfx:feat-stable-signed-url

Conversation

@alvarowolfx
Copy link
Copy Markdown
Collaborator

@alvarowolfx alvarowolfx commented Jan 8, 2026

Towards #3645

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jan 8, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 8, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.77%. Comparing base (2453c93) to head (de314d4).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4185   +/-   ##
=======================================
  Coverage   94.77%   94.77%           
=======================================
  Files         187      187           
  Lines        7116     7116           
=======================================
  Hits         6744     6744           
  Misses        372      372

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alvarowolfx alvarowolfx mentioned this pull request Jan 8, 2026
Closed
@alvarowolfx alvarowolfx mentioned this pull request Jan 9, 2026
Merged
alvarowolfx added a commit that referenced this pull request Jan 9, 2026
@alvarowolfx
impl(storage): move from tokio::sync::SetOnce to std::sync::OnceLock (#…
aba90f6 
…4198)

tokio::sync::SetOnce required newer version of tokio. Move to `std` lib
alternative.

Towards #3645 and fix minimal-version check on
#4185
@alvarowolfx alvarowolfx mentioned this pull request Jan 9, 2026
Merged
ldetmer pushed a commit to ldetmer/google-cloud-rust that referenced this pull request Jan 9, 2026
@alvarowolfx @ldetmer
impl(storage): move from tokio::sync::SetOnce to std::sync::OnceLock (g…
2d7109e 
…oogleapis#4198)

tokio::sync::SetOnce required newer version of tokio. Move to `std` lib
alternative.

Towards googleapis#3645 and fix minimal-version check on
googleapis#4185
@alvarowolfx alvarowolfx marked this pull request as ready for review January 9, 2026 16:26
@alvarowolfx alvarowolfx requested review from a team January 9, 2026 16:26
dbolduc
dbolduc reviewed Jan 9, 2026
View reviewed changes
src/auth/Cargo.toml Outdated
# https://github.com/googleapis/google-cloud-rust/issues/3237
# https://github.com/googleapis/google-cloud-rust/issues/3265
version = "1.4.0"
version = "1.5.0"
Copy link
Copy Markdown
Member

@dbolduc dbolduc Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auth was already bumped in #4152

Copy link
Copy Markdown
Collaborator Author

@alvarowolfx alvarowolfx Jan 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to find why minimal-version check was failing https://github.com/googleapis/google-cloud-rust/runs/59931178068. I can't repro locally

Copy link
Copy Markdown
Member

@dbolduc dbolduc Jan 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your change to make the workspace version of auth 1.4 in Cargo.toml is probably the fix.

The build was failing because it tried to build storage against auth 1.3 which didn't have any of the new signer stuff.

Copy link
Copy Markdown
Collaborator Author

@alvarowolfx alvarowolfx Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I thought that bumping was gonna solve the issue, I just missed that auth was already bumped before. Thanks

dbolduc
dbolduc approved these changes Jan 9, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@alvarowolfx alvarowolfx merged commit 3cef409 into googleapis:main Jan 9, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbolduc dbolduc dbolduc approved these changes

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alvarowolfx @dbolduc