fix(storage): Add missing bucket condition in SignerV4#post_object #5702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dazuma
approved these changes
Apr 24, 2020
This was referenced Apr 25, 2020
frankyn
reviewed
Apr 29, 2020
|
|
||
| def required_fields issuer, time | ||
| { | ||
| "bucket" => @bucket_name, |
Contributor
There was a problem hiding this comment.
@quartzmo does this output a field bucket in returned fields? We may have already discussed this but double checking.
Member
Author
There was a problem hiding this comment.
Yes, it looks like it does. I think I remember now that you wrote somewhere that it shouldn't? Should I ensure that bucket is not added to the PostObject fields in a new PR?
Contributor
There was a problem hiding this comment.
Gotcha, yes please, could you update it to only include the name in the policy only and not return it as a field.?
quartzmo
added a commit
to quartzmo/google-cloud-ruby
that referenced
this pull request
Apr 29, 2020
* Ensure bucket is not returned in PostObject fields. refs: googleapis#5702
quartzmo
added a commit
that referenced
this pull request
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bucket.bucketcondition inSignerV4#post_object.refs: googleapis/conformance-tests#29
refs: googleapis/conformance-tests#31