Skip to content

fix: storage to use correct form for custom metadata #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
frankyn merged 1 commit into from
Apr 23, 2020
Merged

fix: storage to use correct form for custom metadata #29

frankyn merged 1 commit into from
Apr 23, 2020

Conversation

@frankyn
Copy link
Contributor

@frankyn frankyn commented Apr 23, 2020 •
edited
Loading

Fixes: #30

@frankyn frankyn marked this pull request as ready for review April 23, 2020 16:09
@frankyn frankyn requested a review from amanda-tarafa April 23, 2020 16:10
@frankyn frankyn merged commit a006da6 into master Apr 23, 2020
@frankyn frankyn deleted the fix-custom-metadata branch April 23, 2020 17:20
@IlyaFaer IlyaFaer mentioned this pull request Apr 24, 2020
Merged
quartzmo added a commit to quartzmo/google-cloud-ruby that referenced this pull request Apr 24, 2020
@quartzmo
test(storage): update conformance tests for V4 POST policies
7cf56ba 
refs: googleapis/conformance-tests#29
@quartzmo quartzmo mentioned this pull request Apr 24, 2020
Merged
quartzmo added a commit to googleapis/google-cloud-ruby that referenced this pull request Apr 25, 2020
@quartzmo
fix(storage): Add missing bucket condition in SignerV4#post_object
7b293a7 
refs: googleapis/conformance-tests#29
refs: googleapis/conformance-tests#31
pr: #5702
@BenWhitehead BenWhitehead mentioned this pull request Apr 27, 2020
Merged
gcf-merge-on-green bot pushed a commit to googleapis/java-conformance-tests that referenced this pull request Apr 27, 2020
@BenWhitehead
deps: bump conformance-tests to fa559a12df52515694ab2e493948b062c50db…
ec8b477 
…4e2 (#121)

googleapis/conformance-tests@fa559a1 fix: address missing condition bucket ([#31](googleapis/conformance-tests#31))
googleapis/conformance-tests@a006da6 use correct form for custom metadata ([#29](googleapis/conformance-tests#29))
googleapis/conformance-tests@17ce622 test(storage): change expiration type to int for signingV4Tests ([#28](googleapis/conformance-tests#28))

Full diff: googleapis/conformance-tests@24a5e23...fa559a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quartzmo quartzmo quartzmo approved these changes

@amanda-tarafa amanda-tarafa Awaiting requested review from amanda-tarafa

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Storage: Use correct custom metadata field

2 participants

@frankyn @quartzmo