Merged
Conversation
GautamSharda
pushed a commit
that referenced
this pull request
Oct 23, 2025
sofisl
approved these changes
Oct 23, 2025
miguelvelezsa
added a commit
that referenced
this pull request
Oct 23, 2025
* feat: remove workspaces configuration * fix: remove preinstall-deps command from github actions * fix: add required permissions in run_condtional_lint and run_on_changed * fix: tsconfig extends path
This was referenced Oct 23, 2025
GautamSharda
pushed a commit
that referenced
this pull request
Oct 29, 2025
Fixes #136 I've double-checked the behavior of gax-python, and it has the check like `if this_settings.retry and this_settings.retry.retry_codes` Similar code exists here, but JavaScript empty array [] is truthy, so it passes to the retryable code path. It should check if the code length explicitly to be consistent with other languages.
GautamSharda
pushed a commit
that referenced
this pull request
Oct 29, 2025
Fixes #136 I've double-checked the behavior of gax-python, and it has the check like `if this_settings.retry and this_settings.retry.retry_codes` Similar code exists here, but JavaScript empty array [] is truthy, so it passes to the retryable code path. It should check if the code length explicitly to be consistent with other languages.
GautamSharda
pushed a commit
that referenced
this pull request
Dec 4, 2025
* chore!: upgrade to Node 18 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update owlbot.py * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update .OwlBot.lock.yaml * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * run lint * add TS configuration file for linting * Delete .github/workflows/issues-no-repro.yaml * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update package.json * retry test * extend timeout * extend timeout to fix flaky test --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed workspaces until we migrate all packages, after that we will enable them again.