chore(deps): update justinbeckwith/linkinator-action action to v2 - autoclosed#136
Closed
renovate-bot wants to merge 1 commit intogoogleapis:mainfrom
Closed
Conversation
Contributor
|
/gcbrun |
GautamSharda
pushed a commit
that referenced
this pull request
Oct 29, 2025
Fixes #136 I've double-checked the behavior of gax-python, and it has the check like `if this_settings.retry and this_settings.retry.retry_codes` Similar code exists here, but JavaScript empty array [] is truthy, so it passes to the retryable code path. It should check if the code length explicitly to be consistent with other languages.
GautamSharda
pushed a commit
that referenced
this pull request
Oct 29, 2025
Fixes #136 I've double-checked the behavior of gax-python, and it has the check like `if this_settings.retry and this_settings.retry.retry_codes` Similar code exists here, but JavaScript empty array [] is truthy, so it passes to the retryable code path. It should check if the code length explicitly to be consistent with other languages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v1->v2Release Notes
JustinBeckwith/linkinator-action (JustinBeckwith/linkinator-action)
v2Compare Source
⚠ BREAKING CHANGES
Features
Bug Fixes
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.