Skip to content

feat(bigtable): enable new auth library and remove async refresh#19943

Merged
bhshkh merged 3 commits into
googleapis:mainfrom
bhshkh:cbt-enable-new-auth
Jun 10, 2026
Merged

feat(bigtable): enable new auth library and remove async refresh#19943
bhshkh merged 3 commits into
googleapis:mainfrom
bhshkh:cbt-enable-new-auth

Conversation

@bhshkh

@bhshkh bhshkh commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Context: b/372244283

@bhshkh bhshkh requested review from a team as code owners June 10, 2026 02:58
@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the Bigtable API. label Jun 10, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables the new authentication library in both the Bigtable client and admin client by adding internaloption.EnableNewAuthLibrary(). Consequently, the temporary dry-run async refresh option and its associated debug metrics (debugTags and newAsyncRefreshErrHandler) have been removed from bigtable/metrics.go. A review comment suggests explicitly returning nil instead of err at the end of createInstruments since err is guaranteed to be nil at that point.

Comment thread bigtable/metrics.go Outdated
bhshkh and others added 2 commits June 9, 2026 20:10
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@bhshkh bhshkh merged commit 0d3697b into googleapis:main Jun 10, 2026
19 checks passed
@bhshkh bhshkh deleted the cbt-enable-new-auth branch June 10, 2026 20:23
bhshkh added a commit that referenced this pull request Jun 10, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.20.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:b7e38e80d677dc6b7266896bb99a33fa62348d3e39d7b8f2f6423e7dc4b35a60
<details><summary>bigtable: v1.49.0</summary>

##
[v1.49.0](bigtable/v1.48.0...bigtable/v1.49.0)
(2026-06-10)

### Features

* enable new auth library and remove async refresh (#19943)
([0d3697b](0d3697b2))

* add traffic diverter and table shim for bigtable (#14633)
([2f3c918](2f3c9184))

* add virtual RPC descriptors (#14648)
([5eedda1](5eedda18))

* add opensession descriptors for bigtable (#14647)
([8968f4f](8968f4fd))

* update API sources and regenerate (#14701)
([a9b7921](a9b79215))

### Bug Fixes

* retry unexpected EOF errors (#13157)
([2b4ac42](2b4ac429))

* disable dynamic channel pool by default and raise default pool size to
10 (#19945)
([5ddf8d4](5ddf8d46))

* raise default connection-recycler MaxAge to 7 days (#19940)
([a7959ef](a7959efc))

</details>
bhshkh added a commit that referenced this pull request Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants