fix(bigtable): retry unexpected EOF errors#13157
Merged
bhshkh merged 3 commits intoMay 30, 2026
Merged
Conversation
Contributor
|
Please merge main / rebase to main |
We see the unexpected EOF error message in logs for large scans. Apparently there is a flaky test that shows the same issue as well: googleapis#10909 Keeping the comparison by message text, because grpc-go returns a gRPC status error with the same message as io.UnexpectedEOF in some places. There are more cases that use the comparison of the error message now, and the grpc-go has some places (see https://github.com/grpc/grpc-go/blob/ae62635cb0e21ae37e7ae5f0f18aaac5e8139834/rpc_util.go#L1033) that return a gRPC status error with the error message of the io.UnexpectedEOF. So I kept the handling by error message text instead of comparing directly to io.UnexpectedEOF.
auto-merge was automatically disabled
April 29, 2026 13:18
Head branch was pushed to by a user without write access
3492fb7 to
123001a
Compare
Contributor
Author
|
@bhshkh rebased |
Contributor
Author
|
@bhshkh it seems that pull request approval is needed here before the merge succeeds. |
bhshkh
approved these changes
May 16, 2026
Contributor
|
@martin-sucha git commit --allow-empty -m "re-run multi-approvers check" |
Contributor
Author
|
@bhshkh I've pushed the empty commit. The |
Contributor
|
Fixes b/369728110 |
hongalex
approved these changes
May 26, 2026
Contributor
Author
bhshkh
added a commit
that referenced
this pull request
Jun 10, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.20.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:b7e38e80d677dc6b7266896bb99a33fa62348d3e39d7b8f2f6423e7dc4b35a60 <details><summary>bigtable: v1.49.0</summary> ## [v1.49.0](bigtable/v1.48.0...bigtable/v1.49.0) (2026-06-10) ### Features * enable new auth library and remove async refresh (#19943) ([0d3697b](0d3697b2)) * add traffic diverter and table shim for bigtable (#14633) ([2f3c918](2f3c9184)) * add virtual RPC descriptors (#14648) ([5eedda1](5eedda18)) * add opensession descriptors for bigtable (#14647) ([8968f4f](8968f4fd)) * update API sources and regenerate (#14701) ([a9b7921](a9b79215)) ### Bug Fixes * retry unexpected EOF errors (#13157) ([2b4ac42](2b4ac429)) * disable dynamic channel pool by default and raise default pool size to 10 (#19945) ([5ddf8d4](5ddf8d46)) * raise default connection-recycler MaxAge to 7 days (#19940) ([a7959ef](a7959efc)) </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been previously discussed at #11276.
I am resubmitting the change again, since we still see the UnexpectedEOF and we are running with this patch in production to retry it.
Apparently there is a flaky test that shows the same issue as well: #10909
There are more cases that use the comparison of the error message now, and the grpc-go has some places that return a gRPC status error with the error message of the io.UnexpectedEOF.
So I kept the handling by error message text instead of comparing directly to io.UnexpectedEOF.