Skip to content

fix: change TestValidateChecksumFromServer error message#13810

Merged
cpriti-os merged 1 commit intogoogleapis:mainfrom
krishnamd-jkp:fix_singleshot
Feb 9, 2026
Merged

fix: change TestValidateChecksumFromServer error message#13810
cpriti-os merged 1 commit intogoogleapis:mainfrom
krishnamd-jkp:fix_singleshot

Conversation

@krishnamd-jkp
Copy link
Contributor

@krishnamd-jkp krishnamd-jkp commented Feb 7, 2026

No description provided.

@krishnamd-jkp krishnamd-jkp requested a review from a team February 7, 2026 11:19
@krishnamd-jkp krishnamd-jkp requested review from a team as code owners February 7, 2026 11:19
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 7, 2026

Summary of Changes

Hello @krishnamd-jkp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the diagnostic clarity of an error message within a test case. By making the checksum mismatch error more descriptive, it aims to provide clearer feedback when data integrity issues are detected, which can assist in quicker identification of corrupted objects.

Highlights

  • Error Message Enhancement: The error message for checksum mismatches in the TestValidateChecksumFromServer test case has been updated to provide more specific details, indicating both the computed and server checksums and suggesting potential object corruption.
Changelog
  • storage/http_client_test.go
    • Modified the expected error message for a 'wrong checksum' scenario in the TestValidateChecksumFromServer function to be more informative.
Activity
  • No human activity (comments, reviews, etc.) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 7, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the expected error message in the TestValidateChecksumFromServer test to reflect a more descriptive error when a checksum mismatch occurs. The new message is clearer and provides a helpful hint to the user about potential data corruption. The change is correct and improves the test's accuracy. The change is straightforward and I have no further suggestions.

@cpriti-os cpriti-os merged commit 0741414 into googleapis:main Feb 9, 2026
10 checks passed
krishnamd-jkp added a commit that referenced this pull request Feb 9, 2026
@krishnamd-jkp
fix: change TestValidateChecksumFromServer error message (#13810)
6eedc9c
This was referenced Feb 9, 2026
Closed
Merged
krishnamd-jkp added a commit that referenced this pull request Feb 10, 2026
@krishnamd-jkp
chore: librarian release pull request: 20260210T090937Z (#13824)
7783bb0 
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.8.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:19bb93e8f1f916c61b597db2bad65dc432f79baaabb210499d7d0e4ad1dffe29
<details><summary>storage: 1.60.0</summary>

##
[1.60.0](storage/v1.59.1...storage/v1.60.0)
(2026-02-10)

### Features

* adding support for max-retry-duration for all api other than
resumable-upload (#13749)
([31c352b](31c352bd))

* support checksum validation in resumable json uploads (#13573)
([337ca07](337ca078))

* Added a new field `ComposeObjectRequest.delete_source_objects` field
(PiperOrigin-RevId: 863087065)
([611f239](611f2392))

### Bug Fixes

* change TestValidateChecksumFromServer error message (#13810)
([0741414](07414143))

* fix panic error in transfermanager downloads (#13815)
([4272271](42722719))

* deadlock in event loop while coordinating channels (#13652)
([7d9d00c](7d9d00c6))

### Documentation

* Updated documentation for `BidiReadObject`, `ReadObjectRequest`, and
`ObjectContexts` (PiperOrigin-RevId: 863087065)
([611f239](611f2392))

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpriti-os cpriti-os cpriti-os approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@krishnamd-jkp @cpriti-os