feat(storage): support checksum validation in resumable json uploads by krishnamd-jkp · Pull Request #13573 · googleapis/google-cloud-go

krishnamd-jkp · 2026-01-11T15:17:30Z

No description provided.

gemini-code-assist · 2026-01-11T15:17:48Z

Summary of Changes

Hello @krishnamd-jkp, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the storage client by introducing checksum validation for resumable JSON uploads, ensuring data consistency during transfers. It also includes routine updates to various Go module dependencies.

Highlights

Checksum Validation for JSON Uploads: Implemented checksum validation for resumable JSON uploads, enhancing data integrity during transfers.
Writer Configuration Clarification: Clarified the behavior of the DisableAutoChecksum field in the Writer struct, explicitly stating its applicability to both gRPC and JSON uploads, with per-chunk checksum calculations for JSON.
Dependency Updates: Updated several Go module dependencies to their latest versions, including cloud.google.com/go/auth, github.com/googleapis/gax-go/v2, and various golang.org/x and google.golang.org packages.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request adds support for checksum validation in resumable JSON uploads by leveraging a new option from an updated google.golang.org/api dependency. The implementation is straightforward and the accompanying documentation update in writer.go is clear. I've added one comment suggesting the addition of a unit test to ensure the new logic is covered and to prevent future regressions. Otherwise, the changes look good.

gemini-code-assist · 2026-01-11T15:18:43Z

storage/http_client.go

+	if !params.disableAutoChecksum {
+		mediaOpts = append(mediaOpts, googleapi.EnableAutoChecksum())
+	}


This change introduces new functionality for checksum validation. To ensure its correctness and prevent future regressions, please consider adding a unit test. The test should verify that googleapi.EnableAutoChecksum() is correctly passed in mediaOpts based on the disableAutoChecksum parameter.

add a test if it can be unit tested.

The surface is not really suitable to run a unit test here. If OpenWriter is called in solitary, there will be a blocked goroutine which is not very ideal.

storage/go.mod

storage/writer.go

cpriti-os · 2026-01-13T08:38:03Z

storage/http_client.go

+	if !params.disableAutoChecksum {
+		mediaOpts = append(mediaOpts, googleapi.EnableAutoChecksum())
+	}


add a test if it can be unit tested.

quartzmo · 2026-01-13T20:49:48Z

@krishnamd-jkp Please use the storage scope for your conventional commits, for example: feat(storage):.

…13573)

PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.8.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:19bb93e8f1f916c61b597db2bad65dc432f79baaabb210499d7d0e4ad1dffe29 <details><summary>storage: 1.60.0</summary> ## [1.60.0](storage/v1.59.1...storage/v1.60.0) (2026-02-10) ### Features * adding support for max-retry-duration for all api other than resumable-upload (#13749) ([31c352b](31c352bd)) * support checksum validation in resumable json uploads (#13573) ([337ca07](337ca078)) * Added a new field `ComposeObjectRequest.delete_source_objects` field (PiperOrigin-RevId: 863087065) ([611f239](611f2392)) ### Bug Fixes * change TestValidateChecksumFromServer error message (#13810) ([0741414](07414143)) * fix panic error in transfermanager downloads (#13815) ([4272271](42722719)) * deadlock in event loop while coordinating channels (#13652) ([7d9d00c](7d9d00c6)) ### Documentation * Updated documentation for `BidiReadObject`, `ReadObjectRequest`, and `ObjectContexts` (PiperOrigin-RevId: 863087065) ([611f239](611f2392)) </details>

feat: support checksum validation in resumable json uploads

6afb655

krishnamd-jkp requested review from a team January 11, 2026 15:17

krishnamd-jkp requested a review from a team as a code owner January 11, 2026 15:17

gemini-code-assist bot reviewed Jan 11, 2026

View reviewed changes

cpriti-os requested changes Jan 13, 2026

View reviewed changes

fix comments

415f509

krishnamd-jkp force-pushed the json_resumable branch from a661427 to 415f509 Compare January 13, 2026 09:28

krishnamd-jkp requested a review from cpriti-os January 13, 2026 17:48

quartzmo changed the title ~~feat: support checksum validation in resumable json uploads~~ feat(storage): support checksum validation in resumable json uploads Jan 13, 2026

cpriti-os approved these changes Jan 14, 2026

View reviewed changes

krishnamd-jkp merged commit 337ca07 into googleapis:main Jan 14, 2026
12 checks passed

cpriti-os mentioned this pull request Jan 28, 2026

chore: librarian release pull request: 20260128T081259Z #13736

Closed

krishnamd-jkp added a commit that referenced this pull request Feb 9, 2026

feat(storage): support checksum validation in resumable json uploads (#…

1aa388c

…13573)

This was referenced Feb 9, 2026

chore: librarian release pull request: 20260209T155747Z #13816

Closed

chore: librarian release pull request: 20260210T090937Z #13824

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(storage): support checksum validation in resumable json uploads#13573

feat(storage): support checksum validation in resumable json uploads#13573
krishnamd-jkp merged 2 commits intogoogleapis:mainfrom
krishnamd-jkp:json_resumable

krishnamd-jkp commented Jan 11, 2026

Uh oh!

gemini-code-assist bot commented Jan 11, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jan 11, 2026

Uh oh!

cpriti-os Jan 13, 2026

Uh oh!

krishnamd-jkp Jan 13, 2026

Uh oh!

Uh oh!

Uh oh!

cpriti-os Jan 13, 2026

Uh oh!

quartzmo commented Jan 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

krishnamd-jkp commented Jan 11, 2026

Uh oh!

gemini-code-assist bot commented Jan 11, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

cpriti-os Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

krishnamd-jkp Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cpriti-os Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

quartzmo commented Jan 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants