fix(auth): restore use of grpc.Dial#11118
Merged
Merged
Conversation
There have been a couple of reports lately around some subtle changes in behaviour of using the new recommend method. There is also a known bug, see grpc/grpc-go#7556. Until the bug is fixed and we have a way forward we will revert to calling the deprecated Dial function. Fixes: googleapis#7556
Member
|
Note that this reverts changes in #10780. |
quartzmo
approved these changes
Nov 12, 2024
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
🤖 I have created a release *beep* *boop* --- ## [0.10.2](https://togithub.com/googleapis/google-cloud-go/compare/auth/v0.10.1...auth/v0.10.2) (2024-11-12) ### Bug Fixes * **auth:** Restore use of grpc.Dial ([#11118](https://togithub.com/googleapis/google-cloud-go/issues/11118)) ([2456b94](https://togithub.com/googleapis/google-cloud-go/commit/2456b943b7b8aaabd4d8bfb7572c0f477ae0db45)), refs [#7556](https://togithub.com/googleapis/google-cloud-go/issues/7556) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
tritone
added a commit
to tritone/google-cloud-go
that referenced
this pull request
Nov 14, 2024
This picks up googleapis#11118 which should fix dial hangs for storage gRPC methods.
tritone
added a commit
that referenced
this pull request
Nov 14, 2024
This picks up #11118 which should fix dial hangs for storage gRPC methods.
|
@quartzmo Previously |
Member
Author
|
@iwinux See the linked grpc bug in the OP for details. |
|
I see no discussion related to |
Member
Author
|
Oh sorry, I misread your question. I think maybe this should be DialContext, you are correct. Ill send a CL. |
Member
Author
|
Ah looking closer into the gRPC code this was correct at the time to avoid that linked bug. DialContext calls NewClient and had this bug. This does appear to be fixed now though, so still proceeding. |
codyoss
added a commit
to codyoss/google-cloud-go
that referenced
this pull request
Mar 31, 2025
We switched to `Dial` orginally because of grpc/grpc-go#7556. Now that this is fixed we can call DialContext again. In the future we still will want to migrate to the new API directly, but this will require more testing. Related: googleapis#11118
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Mar 31, 2025
We switched to `Dial` orginally because of grpc/grpc-go#7556. Now that this is fixed we can call DialContext again. In the future we still will want to migrate to the new API directly, but this will require more testing. Related: #11118
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been a couple of reports lately around some subtle changes in behaviour of using the new recommend method. There is also a known bug, see grpc/grpc-go#7556. Until the bug is fixed and we have a way forward we will revert to calling the deprecated Dial function.
Fixes: #10780