Skip to content

chore(auth): fix staticcheck errors#10780

Merged
julieqiu merged 2 commits into
googleapis:mainfrom
julieqiu:p1
Aug 29, 2024
Merged

chore(auth): fix staticcheck errors#10780
julieqiu merged 2 commits into
googleapis:mainfrom
julieqiu:p1

Conversation

@julieqiu

@julieqiu julieqiu commented Aug 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Fix these issues:

credentials/detect.go:102:12: metadata.ProjectID is deprecated: Please use the context aware variant [ProjectIDWithContext].  (SA1019)
credentials/idtoken/compute.go:47:11: metadata.ProjectID is deprecated: Please use the context aware variant [ProjectIDWithContext].  (SA1019)
grpctransport/grpctransport.go:294:9: grpc.DialContext is deprecated: use NewClient instead.  Will be supported throughout 1.x.  (SA1019)
grpctransport/pool_test.go:71:16: grpc.Dial is deprecated: use NewClient instead.  Will be supported throughout 1.x.  (SA1019)
internal/transport/s2a.go:87:9: metadata.Get is deprecated: Please use the context aware variant [GetWithContext].  (SA1019)

For #10779

@julieqiu julieqiu requested a review from a team August 28, 2024 01:50
@quartzmo quartzmo mentioned this pull request Aug 28, 2024
Open
@julieqiu julieqiu enabled auto-merge (squash) August 29, 2024 14:11
@julieqiu julieqiu merged commit be2d56d into googleapis:main Aug 29, 2024
@erezrokah

erezrokah commented Nov 6, 2024

Copy link
Copy Markdown

Hello 👋 FYI we're discussing this change in grpc/grpc-go#7556 (comment). The change from DialContext to NewClient also changes the schema from passthrough to DNS (see https://github.com/grpc/grpc-go/blob/master/Documentation/anti-patterns.md#the-wrong-way-grpcdial) which is breaking for some clients that use this SDK

@erezrokah erezrokah mentioned this pull request Nov 6, 2024
Closed
@erezrokah

erezrokah commented Nov 6, 2024

Copy link
Copy Markdown

Opened a bug report #11089

@erezrokah erezrokah mentioned this pull request Nov 12, 2024
Closed
@quartzmo quartzmo mentioned this pull request Nov 12, 2024
Merged
@apstndb apstndb mentioned this pull request Mar 7, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quartzmo quartzmo quartzmo approved these changes

Assignees

@quartzmo quartzmo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@julieqiu @erezrokah @quartzmo