This repository was archived by the owner on Nov 18, 2025. It is now read-only.
fix: use the full type name for ErrorInfo#1093
Merged
summer-ji-eng merged 1 commit intogoogleapis:masterfrom Aug 31, 2021
Merged
fix: use the full type name for ErrorInfo#1093summer-ji-eng merged 1 commit intogoogleapis:masterfrom
summer-ji-eng merged 1 commit intogoogleapis:masterfrom
Conversation
Contributor
|
Hello @idan-at , thank you sent the pull request. Try to understand what error or issue you met for non-full type error info? |
Contributor
Author
|
@summer-ji-eng see googleapis/google-cloud-node-core#359 for a detailed explanation. unrelated, can you please explain why aren’t the tests running? Is it something I missed? |
Contributor
|
@idan-at I see the problem. I am fixing it now. I should sent out the PR by EOD. |
summer-ji-eng
approved these changes
Aug 31, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Aug 31, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [2.24.3](https://www.github.com/googleapis/gax-nodejs/compare/v2.24.2...v2.24.3) (2021-08-31) ### Bug Fixes * use the full type name for ErrorInfo ([#1093](https://www.github.com/googleapis/gax-nodejs/issues/1093)) ([c1e646a](https://www.github.com/googleapis/gax-nodejs/commit/c1e646abf148ab55da4dcdfc65e7d2647d0208a9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes googleapis/google-cloud-node-core#359 🦕