Skip to content

promote ErrorInfo feature fails in runtime when using a stricter version of protobufJs #359

@eyalpost

Description

@eyalpost

We use a patched version of protobufJs with a stricter version of the lookupType function
Our strict version fails, for example, when using
root.lookupType('StringValue') instead of root.lookupType('google.protobuf.StringValue')
Why did we create this patch? because otherwise it allowed invalid proto files that protobufJs would parse correctly while other tools won't.

In one of your latest releases, you introduced this change:
https://github.com/googleapis/gax-nodejs/pull/1070/files#diff-bc32e28b99aecd547a9a9d5fe123b7a41096b4f798f4b01d03c049bd1148cd33R66
(Line 66 is the important one) where a lookup for 'ErrorInfo' is made instead of the full type name 'google.rpc.ErrorInfo' (just like it is done in the lines above it).

This change fails on our side because the patched protobufJs version is used in runtime. Any chance to see a fix on your side which uses the correct full name of the type instead of just ErrorInfo?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions