Skip to content
This repository was archived by the owner on Jul 13, 2025. It is now read-only.

Revert "Fix enum imports (#2430)"#2440

Closed
andreamlin wants to merge 1 commit intogoogleapis:masterfrom
andreamlin:revert_enum
Closed

Revert "Fix enum imports (#2430)"#2440
andreamlin wants to merge 1 commit intogoogleapis:masterfrom
andreamlin:revert_enum

Conversation

@andreamlin
Copy link
Copy Markdown
Contributor

@andreamlin andreamlin commented Nov 19, 2018

This reverts commit e72072a. (PR #2430)

It broke artman CircleCI: https://circleci.com/gh/googleapis/artman/8422#artifacts/containers/0

#2441 is also a fix for the same problem.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 19, 2018

Codecov Report

Merging #2440 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2440      +/-   ##
============================================
- Coverage     86.44%   86.43%   -0.01%     
+ Complexity     5278     5274       -4     
============================================
  Files           458      458              
  Lines         21047    21035      -12     
  Branches       2286     2285       -1     
============================================
- Hits          18194    18182      -12     
  Misses         2036     2036              
  Partials        817      817
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/google/api/codegen/util/TypeName.java 88.63% <ø> (-0.5%) 15 <0> (-1)
...in/java/com/google/api/codegen/util/TypeAlias.java 87.5% <ø> (-1.39%) 7 <0> (-1)
.../transformer/StandardImportSectionTransformer.java 84% <100%> (-1.72%) 10 <0> (-1)
...n/java/com/google/api/codegen/util/ImportType.java 100% <100%> (ø) 1 <0> (ø) ⬇️
...n/transformer/java/JavaModelTypeNameConverter.java 86.66% <100%> (-0.48%) 37 <0> (-1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0f0990...90d6ad7. Read the comment docs.

@andreamlin
Copy link
Copy Markdown
Contributor Author

PTAL

@andreamlin
Copy link
Copy Markdown
Contributor Author

Closed b/c a fix was applied.

@andreamlin andreamlin closed this Nov 20, 2018
@andreamlin andreamlin deleted the revert_enum branch December 8, 2018 00:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants