This repository was archived by the owner on Jul 13, 2025. It is now read-only.
Merged
Conversation
Contributor
Author
|
PTAL |
pongad
approved these changes
Nov 14, 2018
Contributor
pongad
left a comment
There was a problem hiding this comment.
This is good with me. Though I think we should get rid of duplicate import statements. We can do that in follow up PR though.
| private TypeName getEnumTypeName(ProtoElement elem) { | ||
| String packageName = getProtoElementPackage(elem); | ||
| String shortName = getShortName(elem); | ||
| String importName = packageName + "." + shortName.substring(0, shortName.indexOf(".")); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
andreamlin
added a commit
to andreamlin/toolkit
that referenced
this pull request
Nov 19, 2018
This reverts commit e72072a.
This was referenced Nov 19, 2018
andreamlin
added a commit
to andreamlin/toolkit
that referenced
this pull request
Nov 27, 2018
This reverts commit e72072a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2431.
e.g. The
com.google...Book.Ratingimport is a compile time error, since the member is referenced asBook.Rating.An alternative is to keep the import as is, but then reference the inner member as
Rating. That is a lesser alternative, because there could be multipleRatinginner entities from different classes, and there would be type clashes.