Skip to content
This repository was archived by the owner on Jul 13, 2025. It is now read-only.

Avoid Indexoutofbounds when getting enum typename#2441

Merged
andreamlin merged 2 commits intogoogleapis:masterfrom
andreamlin:fix_enum
Nov 19, 2018
Merged

Avoid Indexoutofbounds when getting enum typename#2441
andreamlin merged 2 commits intogoogleapis:masterfrom
andreamlin:fix_enum

Conversation

@andreamlin
Copy link
Copy Markdown
Contributor

@andreamlin andreamlin commented Nov 19, 2018 •
edited
Loading

Fixes https://circleci.com/gh/googleapis/artman/8422#artifacts/containers/0 and the issue raised by ArrayOutOfBounds.

Tested by running artman --local generate java_gapic on some of the failing jobs in https://circleci.com/gh/googleapis/artman/8422#artifacts/containers/0, e.g. google/cloud/language/artman_language_v1beta2.yaml

Hopefully soon we'll run all artman smoketests (#2443) on gapic-generator:master to catch errors like these and prevent firedrills on artman releases.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 19, 2018 •
edited
Loading

Codecov Report

Merging #2441 into master will decrease coverage by 0.14%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2441      +/-   ##
============================================
- Coverage     86.58%   86.43%   -0.15%     
- Complexity     5275     5278       +3     
============================================
  Files           458      458              
  Lines         21000    21050      +50     
  Branches       2278     2287       +9     
============================================
+ Hits          18182    18195      +13     
- Misses         2003     2037      +34     
- Partials        815      818       +3
Impacted Files Coverage Δ Complexity Δ
...n/transformer/java/JavaModelTypeNameConverter.java 86.01% <50%> (-1.13%) 38 <0> (ø)
...m/google/api/codegen/metacode/InitValueConfig.java 72.22% <0%> (-27.78%) 12% <0%> (ø)
...ansformer/ruby/RubyGapicSurfaceDocTransformer.java 81.81% <0%> (-12.22%) 15% <0%> (+1%)
...a/com/google/api/codegen/config/DiscoApiModel.java 67.64% <0%> (-11.67%) 9% <0%> (ø)
...odegen/transformer/DiscoGapicInterfaceContext.java 65.04% <0%> (-2.96%) 28% <0%> (-2%)
...e/api/codegen/gapic/CommonGapicCodePathMapper.java 94.59% <0%> (-2.63%) 15% <0%> (ø)
...a/com/google/api/codegen/config/ProtoApiModel.java 89.74% <0%> (-2.37%) 17% <0%> (ø)
...ava/com/google/api/codegen/gapic/GapicContext.java 50% <0%> (-1.86%) 5% <0%> (ø)
...om/google/api/codegen/config/ProtoMethodModel.java 85.29% <0%> (-1.28%) 33% <0%> (ø)
...n/transformer/java/JavaSurfaceTestTransformer.java 90.68% <0%> (-1.27%) 32% <0%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0beaa5c...5e0f643. Read the comment docs.

@andreamlin
Copy link
Copy Markdown
Contributor Author

andreamlin commented Nov 19, 2018

PTAL

@andreamlin andreamlin mentioned this pull request Nov 19, 2018
Closed
@andreamlin andreamlin mentioned this pull request Nov 19, 2018
Closed
@andreamlin andreamlin merged commit ad593e6 into googleapis:master Nov 19, 2018
@andreamlin andreamlin deleted the fix_enum branch November 19, 2018 21:47
@tseaver
Copy link
Copy Markdown
Contributor

tseaver commented Nov 19, 2018

Might be the cause of #2429?

@andreamlin andreamlin mentioned this pull request Nov 19, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@michaelbausor michaelbausor michaelbausor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andreamlin @codecov-io @tseaver @michaelbausor