Skip to content
This repository was archived by the owner on Jul 13, 2025. It is now read-only.

Run Artman smoke tests as part of CircleCI#2443

Merged
andreamlin merged 9 commits intogoogleapis:masterfrom
andreamlin:artman_smoke
Nov 28, 2018
Merged

Run Artman smoke tests as part of CircleCI#2443
andreamlin merged 9 commits intogoogleapis:masterfrom
andreamlin:artman_smoke

Conversation

@andreamlin
Copy link
Copy Markdown
Contributor

@andreamlin andreamlin commented Nov 19, 2018

Run the full suite of artman smoke tests. This does even more tightly couple gapic-generator to artman for now, but it will save us time down the road when we go to release artman and gapic-generator has broken artman.

Soon after this, I can put in a CircleCI job filter so these smoke tests only run on the master branch, given that they take a long time (~40 minutes).

@andreamlin andreamlin changed the title Run Artman smoke tests (WIP) Run Artman smoke tests Nov 21, 2018
@andreamlin andreamlin changed the title Run Artman smoke tests Run Artman smoke tests as part of CircleCI Nov 21, 2018
@andreamlin
Copy link
Copy Markdown
Contributor Author

PTAL

Check out https://circleci.com/gh/googleapis/gapic-generator/9989 for the artman smoke test run!

Copy link
Copy Markdown
Contributor

@alexander-fenster alexander-fenster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see how it works!

@andreamlin
Copy link
Copy Markdown
Contributor Author

Oh wow it caught some actual failures that are locally reproducible, namely the containeranalysis_v1beta1 artman failures.

@andreamlin
Copy link
Copy Markdown
Contributor Author

This is blocked by #2454, which is a regression in gapic-generator that prevents some artman calls from succeeding.

@codecov-io
Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@bfb49ba). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2443   +/-   ##
=========================================
  Coverage          ?   86.53%           
  Complexity        ?     5289           
=========================================
  Files             ?      458           
  Lines             ?    21055           
  Branches          ?     2298           
=========================================
  Hits              ?    18219           
  Misses            ?     2011           
  Partials          ?      825

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfb49ba...be3a78f. Read the comment docs.

@andreamlin
Copy link
Copy Markdown
Contributor Author

https://github.com/circleci/circleci-images/issues/275 causes the Ruby failure

@andreamlin andreamlin merged commit b1ef2da into googleapis:master Nov 28, 2018
@andreamlin andreamlin deleted the artman_smoke branch November 28, 2018 00:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants