Add methods to ResourceName interface #46

andreamlin · 2018-02-27T22:53:13Z

No description provided.

andreamlin · 2018-02-27T22:53:17Z

Blocked on googleapis/protoc-java-resource-names-plugin#28.

andreamlin · 2018-02-28T01:01:20Z

PTAL

codecov-io · 2018-02-28T01:02:46Z

Codecov Report

Merging #46 into master will increase coverage by 0.78%.
The diff coverage is 62.5%.

@@             Coverage Diff              @@
##             master      #46      +/-   ##
============================================
+ Coverage     60.23%   61.01%   +0.78%     
- Complexity      140      145       +5     
============================================
  Files            14       14              
  Lines           606      613       +7     
  Branches         91       92       +1     
============================================
+ Hits            365      374       +9     
+ Misses          219      215       -4     
- Partials         22       24       +2

Impacted Files	Coverage Δ	Complexity Δ
.../google/api/resourcenames/UntypedResourceName.java	`42.85% <62.5%> (+42.85%)`	`5 <3> (+5)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efe02a9...1387841. Read the comment docs.

src/main/java/com/google/api/resourcenames/UntypedResourceName.java


+  @Override
+  /* Returns a map with an empty String as the sole key, which maps to the raw value of this ResourceName. */
+  public Map<String, String> getFieldValuesMap() {


src/main/java/com/google/api/resourcenames/UntypedResourceName.java

+  }
+
+  @Override
+  /* Returns the raw value of this ResourceName, regardless of the fieldName parameter. */


src/main/java/com/google/api/resourcenames/UntypedResourceName.java

+  /* Returns the raw value of this ResourceName iff fieldName.equals(""), else returns null. */
+  @Override
+  public String getFieldValue(String fieldName) {
+    return fieldValuesMap.get("");


src/main/java/com/google/api/resourcenames/UntypedResourceName.java

+      }
+    }
+    return fieldValuesMap;
+  }


version.txt

@@ -1 +1 @@
-1.4.0
+1.3.1-SNAPSHOT


src/main/java/com/google/api/resourcenames/ResourceNameFactory.java

+ */
+package com.google.api.resourcenames;
+
+public interface ResourceNameFactory<T extends ResourceName> {


src/main/java/com/google/api/resourcenames/ResourceNameFactory.java

+public interface ResourceNameFactory<T extends ResourceName> {
+
+  /* Create a new ResourceName from a formatted String representing a ResourceName. */
+  T parseFrom(String formattedString);


…n-java into resourceNameMethods

garrettjonesgoogle

Ok I'm good with this PR, but we should hold off on merging until we have regenerated api-client-staging and released that code in google-cloud-java.

Update ResourceName.java

19c6525

andreamlin mentioned this pull request Feb 27, 2018

Parse ResourceName into http endpoint path googleapis/gax-java#481

Merged

andreamlin added 2 commits February 27, 2018 16:43

add Map import

1cd4ae7

update UntypedResourceName

dcf59c8

andreamlin requested a review from garrettjonesgoogle February 28, 2018 01:01

garrettjonesgoogle reviewed Feb 28, 2018

View reviewed changes

andreamlin added 4 commits February 27, 2018 17:11

formatting for UntypedResourceName

a50b92d

synchronized fieldValuesMap for UntypedResourceName.java

acabf89

adding ResourceNameFactory

ba8dee4

merge master

b7e00db

garrettjonesgoogle reviewed Mar 1, 2018

View reviewed changes

andreamlin added 5 commits March 1, 2018 08:46

parameterize ResourceNameFactory

12457d5

revert version.txt to origin/master

f10b002

use getFieldValuesMap() in untypedresourcename.getfieldstringvalue()

69293fa

add null check in UntypedResourceName and make tests for that class

3b403c1

null check in UntypedResourceName and tests for that class

f13ed35

garrettjonesgoogle reviewed Mar 1, 2018

View reviewed changes

andreamlin added 3 commits March 1, 2018 10:58

@BetaApi ResourceNameFactory

65baa19

Merge branch 'resourceNameMethods' of github.com:googleapis/api-commo…

5cdc319

…n-java into resourceNameMethods

ResourceNameFactory rename parseFrom() to parse()

1387841

garrettjonesgoogle reviewed Mar 1, 2018

View reviewed changes

andreamlin merged commit c01543b into master Mar 6, 2018

miraleung pushed a commit that referenced this pull request Jun 4, 2020

Add methods to ResourceName interface (#46)

a647ed5

		@@ -1 +1 @@
		1.4.0
		1.3.1-SNAPSHOT

Add methods to ResourceName interface #46

Add methods to ResourceName interface #46

Uh oh!

Conversation

andreamlin commented Feb 27, 2018

Uh oh!

andreamlin commented Feb 27, 2018

Uh oh!

andreamlin commented Feb 28, 2018

Uh oh!

codecov-io commented Feb 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

garrettjonesgoogle left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov-io commented Feb 28, 2018 •

edited

Loading