Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

Add methods to ResourceName classes #28

Merged
andreamlin merged 4 commits into from
Feb 28, 2018
Merged

Add methods to ResourceName classes #28

andreamlin merged 4 commits into from
Feb 28, 2018

Conversation

@andreamlin
Copy link
Contributor

@andreamlin andreamlin commented Feb 27, 2018

No description provided.

@andreamlin
Copy link
Contributor Author

andreamlin commented Feb 27, 2018

PTAL

@andreamlin
Copy link
Contributor Author

andreamlin commented Feb 27, 2018

Not sure what the python2.7 build failure is.

@andreamlin andreamlin mentioned this pull request Feb 27, 2018
Closed
@andreamlin
Copy link
Contributor Author

andreamlin commented Feb 27, 2018

The resulting changes in api-client-staging would be googleapis/api-client-staging#601.

garrettjonesgoogle
garrettjonesgoogle reviewed Feb 27, 2018
View reviewed changes
test/testdata/java_archived_book_name.baseline Outdated
}

public String getFieldValue(String fieldName) {
return fieldMap.get(fieldName);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

test/testdata/java_archived_book_name.baseline
public Map<String, String> getFieldValuesMap() {
if (fieldMap != null) {
return fieldMap;
}

This comment was marked as spam.

Sign in to view

@garrettjonesgoogle
Copy link
Member

garrettjonesgoogle commented Feb 27, 2018

I'm also not sure about the python 2.7 build failure; I have been ignoring it.

@andreamlin
Copy link
Contributor Author

andreamlin commented Feb 27, 2018

I will wait to regen the api-client-staging branch after all the baseline changes are reviewed.

@andreamlin andreamlin mentioned this pull request Feb 27, 2018
Merged
pongad
pongad reviewed Feb 28, 2018
View reviewed changes
test/testdata/java_archived_book_name.baseline Outdated
if (fieldValuesMap != null) {
return fieldValuesMap;
}
ImmutableMap.Builder<String, String> fieldMapBuilder = ImmutableMap.builder();

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@andreamlin
Copy link
Contributor Author

andreamlin commented Feb 28, 2018 •
edited
Loading

googleapis/api-client-staging#601 is updated with updated ResourceName classes generated with this PR.

PTAL

garrettjonesgoogle
garrettjonesgoogle approved these changes Feb 28, 2018
View reviewed changes
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreamlin andreamlin merged commit 98fa3ab into googleapis:master Feb 28, 2018
@andreamlin andreamlin deleted the resource_name branch February 28, 2018 23:44
@andreamlin andreamlin changed the title Add methods to ResourceName interface Add methods to ResourceName classes Feb 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@pongad pongad pongad approved these changes

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andreamlin @garrettjonesgoogle @pongad