fix(temporary): Don't run ctrl+c exit test on windows#9785
Conversation
This test is failing on every PR and every run against main. Since we know this is broken, let's remove the noise and fix it. By allowing it to continue failing, we are potentially covering up new problems being introduced. We should definitely follow up on this asap, either fixing it to pass on windows, determining that it doesn't need to (does ctrl c on windows even make sense? i'm not sure, it's been a while XD - does it copy?), or removing it if it's not necessary. In the meantime let's remove the noise.
Summary of ChangesHello @bobcatfish, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a temporary fix to reduce continuous integration noise by skipping a persistently failing Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request temporarily disables the 'Ctrl+C exit' integration test on Windows to address a consistent failure that is creating noise in CI. The change correctly uses vitest's it.skipIf with process.platform === 'win32' to conditionally skip the test. Including a comment that references the tracking issue (#9782) is an excellent practice for ensuring this temporary measure is addressed in the future. The change is straightforward, correct, and appropriate for its stated goal. I did not find any issues of high or critical severity.
|
Size Change: -2 B (0%) Total Size: 17.4 MB ℹ️ View Unchanged
|
TLDR
This test is failing on every PR and every run against main. Since we know this is broken, let's remove the noise and fix it. By allowing it to continue failing, we are potentially covering up new problems being introduced.
Dive Deeper
We should definitely follow up on this asap, either fixing it to pass on windows, determining that it doesn't need to (does ctrl c on windows even make sense? i'm not sure, it's been a while XD - does it copy?), or removing it if it's not necessary. In the meantime let's remove the noise.
Reviewer Test Plan
Well hopefully this will result in the e2e test suites all passing for this PR.
Testing Matrix
n/a
Linked issues / bugs
#9782 will track actually fixing the test