fix(core): ensure retry sets defaults for nullish values passed into options#9540
Merged
Conversation
|
Size Change: +117 B (0%) Total Size: 17.4 MB ℹ️ View Unchanged
|
abhipatel12
approved these changes
Sep 25, 2025
abhipatel12
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for adding this!
geoffdowns
pushed a commit
to geoffdowns/gemini-cli
that referenced
this pull request
Sep 26, 2025
…options (google-gemini#9540) Co-authored-by: Abhi <43648792+abhipatel12@users.noreply.github.com>
jkcinouye
pushed a commit
that referenced
this pull request
Sep 29, 2025
…options (#9540) Co-authored-by: Abhi <43648792+abhipatel12@users.noreply.github.com>
thacio
added a commit
to thacio/auditaria
that referenced
this pull request
Oct 4, 2025
…lish values passed into options (google-gemini#9540)
giraffe-tree
pushed a commit
to giraffe-tree/gemini-cli
that referenced
this pull request
Oct 10, 2025
…options (google-gemini#9540) Co-authored-by: Abhi <43648792+abhipatel12@users.noreply.github.com>
cocosheng-g
pushed a commit
that referenced
this pull request
May 6, 2026
…options (#9540) Co-authored-by: Abhi <43648792+abhipatel12@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
This PR filters out null or undefined option values that may get passed in to
retryWithBackoffand ensures that in these cases, the defaults fromDEFAULT_RETRY_OPTIONSkick in.Dive Deeper
We add
cleanOptionsto filter out null/undefined values for any of the option fields that get passed in, ensuring that the spread syntax merges in default values for the null/undefined values.Reviewer Test Plan
N/A
Testing Matrix
Linked issues / bugs
Progress on #4137, #9030