revert: fix(ci): robust version checking in release verification (#26337)#26450
revert: fix(ci): robust version checking in release verification (#26337)#26450
Conversation
)" This reverts commit 8fb1b5a.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request reverts the modifications made in a previous commit regarding version verification within the CI pipeline. By restoring the original implementation, the project ensures consistency with the established release verification workflow. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Size Change: -4 B (0%) Total Size: 33.9 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
This pull request updates the release verification action by removing the suppression of standard error when checking the gemini CLI version. A review comment identifies a potential failure point in the npx command when using package specifiers and recommends using the --package and --yes flags for better reliability in CI.
| working-directory: '${{ inputs.working-directory }}' | ||
| run: |- | ||
| gemini_version=$(npx --prefer-online "${INPUTS_NPM_PACKAGE}" --version 2>/dev/null) | ||
| gemini_version=$(npx --prefer-online "${INPUTS_NPM_PACKAGE}" --version) |
There was a problem hiding this comment.
The npx command as written is likely to fail because it attempts to execute a command named after the full package specifier (e.g., @google/gemini-cli@latest), which does not exist. For scoped packages where the binary name (gemini) differs from the package name, or when using a version specifier, you should explicitly specify the package and the command. Additionally, using --yes is recommended in CI to avoid interactive prompts.
gemini_version=$(npx --yes --prefer-online --package "${INPUTS_NPM_PACKAGE}" gemini --version)
Summary
Revert "fix(ci): robust version checking in release verification (#26337)"
Details
This PR did nothing as
$()already reads only from std out.Related Issues
For #26359