fix(ci): robust version checking in release verification#26337
fix(ci): robust version checking in release verification#26337
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the reliability of the release verification CI process. By suppressing error stream output during version checks, the workflow now correctly captures the version string without interference from unrelated warnings or diagnostic messages. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request modifies the .github/actions/verify-release/action.yml file to suppress standard error output when retrieving the gemini version. The review feedback suggests enhancing the robustness of these version checks by trimming whitespace and ensuring the captured version string is not empty, which prevents potential false positives from unexpected tool output.
|
Size Change: -4 B (0%) Total Size: 33.9 MB
ℹ️ View Unchanged
|
Summary
Discard error output when fetching version.
Details
Harmless warnings broke the nightly build because it was expecting the version to be the only output.