feat(ui): added microphone and updated placeholder for voice mode#26270
feat(ui): added microphone and updated placeholder for voice mode#26270
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the user experience for voice mode by introducing a clear visual indicator and updated instructional text. These changes ensure that users are aware of the active voice mode status and understand how to interact with it, addressing the issue referenced. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request enhances the InputPrompt component's voice mode UI by introducing a dynamic placeholder and updating the microphone emoji. Feedback identifies a 'jumpy' UI transition when recording starts and suggests maintaining a consistent microphone prefix to ensure layout stability. This improvement requires removing the redundant emoji from the 'Listening...' status and updating unit tests to reflect the refined output.
|
Size Change: +31 B (0%) Total Size: 33.9 MB
ℹ️ View Unchanged
|
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Abhijit-2592
left a comment
There was a problem hiding this comment.
Thank you for the updates to the voice mode UI! The new microphone emoji and consolidated placeholder look good. However, there are a few minor layout issues that cause a 'jumpy' effect when toggling the recording state. I've left some inline comments with suggestions to keep the microphone prefix stable and fix the spacing.
Abhijit-2592
left a comment
There was a problem hiding this comment.
Thank you for the updates to the voice mode UI! The new microphone emoji and consolidated placeholder look good. However, there are a few minor layout issues that cause a 'jumpy' effect when toggling the recording state. I've left some inline comments with suggestions to keep the microphone prefix stable and fix the spacing.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Abhijit-2592
left a comment
There was a problem hiding this comment.
Approved once the comments are fixed
…ogle-gemini#26270) Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ogle-gemini#26270) Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Summary
Added microphone and updated placeholder for when the user is in voice mode.
Details
This is to make it obvious to the user that they're in voice mode and can talk anytime while it is enabled.
Related Issues
Closes #25490
How to Validate
Type

/voiceand then take a look at the input prompt. It should look like this:Pre-Merge Checklist