Skip to content

fix(ux): added error message for ENOTDIR#26128

Merged
devr0306 merged 1 commit intomainfrom
enotdir
Apr 28, 2026
Merged

fix(ux): added error message for ENOTDIR#26128
devr0306 merged 1 commit intomainfrom
enotdir

Conversation

@devr0306
Copy link
Copy Markdown
Contributor

Summary

Added error message for ENOTDIR

Related Issues

Closes #23350

How to Validate

Run tests

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@devr0306 devr0306 requested a review from a team as a code owner April 28, 2026 16:51
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user experience by providing more descriptive error messages when a filesystem operation fails due to an ENOTDIR error. By clarifying that the issue relates to an incorrect path component, it helps users quickly identify and resolve configuration or path-related problems.

Highlights

  • Error Handling Improvement: Added a specific, user-friendly error message for the ENOTDIR filesystem error code to improve diagnostic clarity.
  • Test Coverage: Included new test cases in the filesystem error utility tests to ensure the ENOTDIR error message is correctly generated for both path-specific and generic scenarios.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces error message handling for the ENOTDIR filesystem error in packages/core. It adds a generator in fsErrorMessages.ts to provide descriptive feedback when a path is not a directory and includes corresponding unit tests in fsErrorMessages.test.ts. I have no feedback to provide.

@github-actions
Copy link
Copy Markdown

Size Change: +170 B (0%)

Total Size: 33.9 MB

Filename Size Change
./bundle/chunk-5IEDF6VX.js 0 B -14.7 MB (removed) 🏆
./bundle/chunk-BNKL4RWD.js 0 B -673 kB (removed) 🏆
./bundle/chunk-IXVDLUTI.js 0 B -3.43 kB (removed) 🏆
./bundle/chunk-RILATMDG.js 0 B -49.2 kB (removed) 🏆
./bundle/chunk-T3GEZ73E.js 0 B -2.73 MB (removed) 🏆
./bundle/chunk-Y4C3OEXJ.js 0 B -3.8 kB (removed) 🏆
./bundle/core-CTKKIYR5.js 0 B -48.1 kB (removed) 🏆
./bundle/devtoolsService-QX3RT62B.js 0 B -27.8 kB (removed) 🏆
./bundle/gemini-ADIZUUMA.js 0 B -574 kB (removed) 🏆
./bundle/interactiveCli-IC2MMJBQ.js 0 B -1.31 MB (removed) 🏆
./bundle/liteRtServerManager-ASWQD7YR.js 0 B -2.08 kB (removed) 🏆
./bundle/oauth2-provider-BHPZDXXI.js 0 B -9.16 kB (removed) 🏆
./bundle/chunk-2BUNYWAT.js 3.43 kB +3.43 kB (new file) 🆕
./bundle/chunk-DI7VH4RU.js 49.2 kB +49.2 kB (new file) 🆕
./bundle/chunk-DT27QQFX.js 2.73 MB +2.73 MB (new file) 🆕
./bundle/chunk-JK5PH5O3.js 673 kB +673 kB (new file) 🆕
./bundle/chunk-VGP4FTRU.js 14.7 MB +14.7 MB (new file) 🆕
./bundle/chunk-WNCSLYQE.js 3.8 kB +3.8 kB (new file) 🆕
./bundle/core-MUCEK22P.js 48.1 kB +48.1 kB (new file) 🆕
./bundle/devtoolsService-L7CBZX57.js 27.8 kB +27.8 kB (new file) 🆕
./bundle/gemini-56NRTG23.js 574 kB +574 kB (new file) 🆕
./bundle/interactiveCli-KYU5J5D7.js 1.31 MB +1.31 MB (new file) 🆕
./bundle/liteRtServerManager-KH77MZ3U.js 2.08 kB +2.08 kB (new file) 🆕
./bundle/oauth2-provider-NMHI7FLQ.js 9.16 kB +9.16 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./bundle/bundled/third_party/index.js 8 MB 0 B
./bundle/chunk-34MYV7JD.js 2.45 kB 0 B
./bundle/chunk-5AUYMPVF.js 858 B 0 B
./bundle/chunk-5PS3AYFU.js 1.18 kB 0 B
./bundle/chunk-664ZODQF.js 124 kB 0 B
./bundle/chunk-DAHVX5MI.js 206 kB 0 B
./bundle/chunk-IUUIT4SU.js 56.5 kB 0 B
./bundle/chunk-MTD736U4.js 1.97 MB 0 B
./bundle/chunk-RJTRUG2J.js 39.8 kB 0 B
./bundle/cleanup-5MYWLDN4.js 0 B -932 B (removed) 🏆
./bundle/devtools-36NN55EP.js 696 kB 0 B
./bundle/dist-T73EYRDX.js 356 B 0 B
./bundle/events-XB7DADIJ.js 418 B 0 B
./bundle/examples/hooks/scripts/on-start.js 188 B 0 B
./bundle/examples/mcp-server/example.js 1.43 kB 0 B
./bundle/gemini.js 4.97 kB 0 B
./bundle/getMachineId-bsd-TXG52NKR.js 1.55 kB 0 B
./bundle/getMachineId-darwin-7OE4DDZ6.js 1.55 kB 0 B
./bundle/getMachineId-linux-SHIFKOOX.js 1.34 kB 0 B
./bundle/getMachineId-unsupported-5U5DOEYY.js 1.06 kB 0 B
./bundle/getMachineId-win-6KLLGOI4.js 1.72 kB 0 B
./bundle/memoryDiscovery-NSOLCG4U.js 980 B 0 B
./bundle/multipart-parser-KPBZEGQU.js 11.7 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 222 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 229 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 13.4 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B
./bundle/src-QVCVGIUX.js 47 kB 0 B
./bundle/start-KTHVSYSS.js 0 B -622 B (removed) 🏆
./bundle/tree-sitter-7U6MW5PS.js 274 kB 0 B
./bundle/tree-sitter-bash-34ZGLXVX.js 1.84 MB 0 B
./bundle/cleanup-TGLDFTVV.js 932 B +932 B (new file) 🆕
./bundle/start-Y65OX7ZS.js 622 B +622 B (new file) 🆕

compressed-size-action

@devr0306 devr0306 added this pull request to the merge queue Apr 28, 2026
@gemini-cli gemini-cli Bot added the area/core Issues related to User Interface, OS Support, Core Functionality label Apr 28, 2026
Merged via the queue into main with commit 8e1ceca Apr 28, 2026
30 checks passed
@devr0306 devr0306 deleted the enotdir branch April 28, 2026 17:28
TirthNaik-99 pushed a commit to TirthNaik-99/gemini-cli that referenced this pull request May 4, 2026
kimjune01 pushed a commit to kimjune01/gemini-cli-claude that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve filesystem error message handling for ENOTDIR Fixes #23350

2 participants