fix(cli): correct alternate buffer warning logic for JetBrains#26067
fix(cli): correct alternate buffer warning logic for JetBrains#26067
Conversation
Ensures that the JetBrains alternate screen buffer warning only fires when the actual alternate buffer is enabled, not just terminalBuffer. Fixes #24790
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where the JetBrains terminal compatibility warning was being triggered erroneously. By refining the logic used to determine if the alternate screen buffer is active, the change ensures that the warning only appears when the specific configuration requiring it is enabled, improving the user experience for those using alternative terminal configurations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the retrieval of the alternate buffer status in packages/cli/src/gemini.tsx by replacing the isAlternateBufferEnabled utility function with a direct call to config.getUseAlternateBuffer(). I have no feedback to provide.
|
Size Change: -214 B (0%) Total Size: 33.9 MB
ℹ️ View Unchanged
|
- BerriAI/litellm#26843 (merge-after-nits) — invite-link onboarding token hardening - google-gemini/gemini-cli#26067 (merge-after-nits) — JetBrains alt-buffer respects user setting - QwenLM/qwen-code#3622 (merge-as-is) — rewind E2E assertion update post isRealUserTurn - QwenLM/qwen-code#3609 (merge-after-nits) — zero-width-space placeholder unification - aaif-goose/goose#8796 (merge-as-is) — newSession _meta wire-protocol field rename
Summary
Fixes issue #24790 where the JetBrains alternate buffer warning was incorrectly firing when the user had
terminalBuffermode enabled butalternateBuffermode disabled.Details
The
isAlternateBufferEnabled(config)helper returnstrueif eitheralternateBufferorterminalBufferis enabled. However, the terminal's physical alternate screen buffer is only entered whenalternateBufferis enabled. The scrolling and rendering issues specific to JetBrains are tied to the actual terminal alternate screen, so the warning should not fire forterminalBuffermode.Changed
packages/cli/src/gemini.tsxto useconfig.getUseAlternateBuffer()for computing theuseAlternateBufferflag used in startup warnings.Related Issues
Fixes #24790
How to Validate
terminalBufferbut ensureUse Alternate Screen Bufferis disabled.Use Alternate Screen Bufferand verify that the warning IS displayed.Pre-Merge Checklist