fix(test): update rewind E2E Test 1 assertion after isRealUserTurn fix#3622
Merged
fix(test): update rewind E2E Test 1 assertion after isRealUserTurn fix#3622
Conversation
Test 1 asserted `say exactly GAMMA3` after pressing Up once in the rewind selector, but that only passed because `/rewind` was incorrectly counted as a user turn. After `isRealUserTurn()` excluded slash commands, the turn list is [ALPHA1, BETA2, GAMMA3] and Up from the initial selection (GAMMA3) lands on BETA2. Update the assertion to match. Ref: #3441 (comment) Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
wenshao
approved these changes
Apr 25, 2026
Collaborator
wenshao
left a comment
There was a problem hiding this comment.
No issues found. LGTM! ✅ — gpt-5.5 via Qwen Code /review
Bojun-Vvibe
added a commit
to Bojun-Vvibe/oss-contributions
that referenced
this pull request
Apr 30, 2026
- BerriAI/litellm#26843 (merge-after-nits) — invite-link onboarding token hardening - google-gemini/gemini-cli#26067 (merge-after-nits) — JetBrains alt-buffer respects user setting - QwenLM/qwen-code#3622 (merge-as-is) — rewind E2E assertion update post isRealUserTurn - QwenLM/qwen-code#3609 (merge-after-nits) — zero-width-space placeholder unification - aaif-goose/goose#8796 (merge-as-is) — newSession _meta wire-protocol field rename
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/test-rewind-e2e.shTest 1 that was passing only because of the off-by-one bug thatisRealUserTurn()later fixed/rewindis excluded from the user turn list, so pressing Up once from the initial selection (GAMMA3) lands on BETA2 — update the assertion fromGAMMA3toBETA2Ref: #3441 (comment)
Test plan
scripts/test-rewind-e2e.shand verify all 5 tests passE2E test output
🤖 Generated with Qwen Code