feat(core): prioritize discussion before formal plan approval#24423
feat(core): prioritize discussion before formal plan approval#24423
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a mandatory consultation step into the agent's planning workflow. By requiring the agent to discuss and reach an informal agreement with the user on the proposed strategy before drafting a formal plan or calling the exit tool, the changes ensure better alignment and reduce the likelihood of rework during the implementation phase. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
🧠 Model Steering GuidanceThis PR modifies files that affect the model's behavior (prompts, tools, or instructions).
This is an automated guidance message triggered by steering logic signatures. |
|
Size Change: +702 B (0%) Total Size: 26.6 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
This pull request updates the Plan Mode workflow to require an informal agreement between the agent and the user on a proposed strategy before a formal plan is drafted or finalized. These changes are reflected in the documentation, tool definitions, and the core system prompt. A review comment suggests refining the prompt in packages/core/src/prompts/snippets.ts by removing the 'in a PREVIOUS turn' constraint, as it may cause unnecessary delays if the user provides agreement in the current turn, while the existing critical rule already prevents premature execution during the initial proposal.
Update the planning workflow and tool definitions to ensure the agent discusses its strategy and reaches an informal agreement with the user before presenting the formal approval dialog via exit_plan_mode. - Mandate informal agreement in snippets.ts Step 2 (Consult) and Step 4 (Review & Approval). - Update exit_plan_mode declaration in dynamic-declaration-helpers.ts. - Align docs/cli/plan-mode.md and docs/tools/planning.md with the updated workflow.
f133f72 to
d49deca
Compare
Updates 'should transition from plan mode to normal execution' eval to align with the new 'informal agreement' prompt mandate introduced in PR #24423, fixing flakiness.
Updates 'should transition from plan mode to normal execution' eval to align with the new 'informal agreement' prompt mandate introduced in PR #24423, fixing flakiness.
Updates 'should transition from plan mode to normal execution' eval to align with the new 'informal agreement' prompt mandate introduced in PR #24423, fixing flakiness.
Update the planning workflow and tool definitions to ensure the agent discusses its strategy and reaches an informal agreement with the user before presenting the formal approval dialog via
exit_plan_mode.snippets.tsStep 2 (Consult) and Step 4 (Review & Approval).exit_plan_modedeclaration indynamic-declaration-helpers.ts.docs/cli/plan-mode.mdanddocs/tools/planning.mdwith the updated workflow.Fixes #24420