feat: provide support for .env files injects via API#1034
Merged
antongolub merged 5 commits intogoogle:mainfrom Dec 27, 2024
Merged
feat: provide support for .env files injects via API#1034antongolub merged 5 commits intogoogle:mainfrom
antongolub merged 5 commits intogoogle:mainfrom
Conversation
Contributor
Author
|
Collaborator
|
What's about this way instead? const loadDotenv = (...files: string[]) => files.reverse().reduce<env>((m, f) => Object.assign(m, parseDotenv(fs.readFileSync(f))), {})
$.env = loadDotenv('.env', '.env.default') |
antongolub
reviewed
Dec 25, 2024
Contributor
Author
Maybe replace it with spread? const loadDotenv = (...files: string[]) =>
files
.reverse()
.reduce<env>((m, f) => ({ ...m, ...parseDotenv(fs.readFileSync(f)) }), {});And why the reverse? $.env = loadDotenv('.env.default', '.env')Are you suggesting we consider an array of strings as well? type Env = NodeJs.Process | string | string[] |
Collaborator
|
I suggest keeping the |
6fae7d2 to
28a2661
Compare
28a2661 to
bb09653
Compare
added 2 commits
December 26, 2024 17:46
antongolub
pushed a commit
to antongolub/zx
that referenced
this pull request
Dec 28, 2024
2 tasks
antongolub
added a commit
that referenced
this pull request
Dec 28, 2024
* refactor: assemble dotenv utils continues #1034 * chore: prettier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #975