[ci] Support XODO comments in commit messages#2998
Conversation
Summary of ChangesHello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the continuous integration (CI) process by extending the existing check for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request extends the check_todo.sh script to also scan the latest commit message for TODO markers. The implementation is straightforward, using git log and rg to find matches and prepending them to the list of TODOs found in files. The logic correctly formats the commit message findings to be compatible with the rest of the script's parsing logic. I have one suggestion to simplify a conditional block for better conciseness.
3ead393 to
8e29e49
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2998 +/- ##
=======================================
Coverage 91.87% 91.87%
=======================================
Files 20 20
Lines 6057 6057
=======================================
Hits 5565 5565
Misses 492 492 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
(s/X/T/, of course) This allows us to leave general XODOs in commit messages that don't naturally belong in any particular file, and PR merging will be blocked until they are removed. gherrit-pr-id: Gc456c89ea3f26105fca5cadcd11ddc5107ed6afe
8e29e49 to
4b2ee00
Compare
(s/X/T/, of course)
This allows us to leave general XODOs in commit messages that don't
naturally belong in any particular file, and PR merging will be blocked
until they are removed.
Latest Update: v5 — Compare vs v4
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gc456c89ea3f26105fca5cadcd11ddc5107ed6afe && git checkout -b pr-Gc456c89ea3f26105fca5cadcd11ddc5107ed6afe FETCH_HEADCheckout
git fetch origin refs/heads/Gc456c89ea3f26105fca5cadcd11ddc5107ed6afe && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gc456c89ea3f26105fca5cadcd11ddc5107ed6afe && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.