Add FromBytes::read_from_io and IntoBytes::write_to_io (#2016)#2046
Merged
Add FromBytes::read_from_io and IntoBytes::write_to_io (#2016)#2046
FromBytes::read_from_io and IntoBytes::write_to_io (#2016)#2046Conversation
Makes progress on #158. Co-authored-by: Joshua Liebow-Feeser <joshlf@users.noreply.github.com> gherrit-pr-id: I9253d6be7407d8d8679ee355e4e71cd9b15b9ff7
Member
Author
|
Backport of #2016 |
jswrenn
approved these changes
Nov 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2046 +/- ##
==========================================
+ Coverage 89.46% 89.51% +0.05%
==========================================
Files 16 16
Lines 5838 5866 +28
==========================================
+ Hits 5223 5251 +28
Misses 615 615 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes progress on #158.
Co-authored-by: Joshua Liebow-Feeser joshlf@users.noreply.github.com
This PR is on branch backport-io.
FromBytes::read_from_ioandIntoBytes::write_to_io(#2016) #2046