Skip to content

Add FromBytes::read_from_io and IntoBytes::write_to_io#2016

Merged
jswrenn merged 1 commit intov0.8.xfrom
io
Nov 8, 2024
Merged

Add FromBytes::read_from_io and IntoBytes::write_to_io#2016
jswrenn merged 1 commit intov0.8.xfrom
io

Conversation

@jswrenn
Copy link
Collaborator

@jswrenn jswrenn commented Nov 4, 2024

Makes progress on #158.

@jswrenn jswrenn requested a review from joshlf November 4, 2024 21:23
joshlf
joshlf requested changes Nov 4, 2024
View reviewed changes
src/lib.rs Outdated
}
}

/// TODO
Copy link
Member

@joshlf joshlf Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Doc comment

src/lib.rs Outdated
Ok(())
}

/// TODO
Copy link
Member

@joshlf joshlf Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Doc comment

src/lib.rs
Copy link
Member

@joshlf joshlf Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Tests

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.64%. Comparing base (1fb6365) to head (c38fc1f).
Report is 3 commits behind head on v0.8.x.

Additional details and impacted files 
@@            Coverage Diff             @@
##           v0.8.x    #2016      +/-   ##
==========================================
+ Coverage   87.59%   87.64%   +0.05%     
==========================================
  Files          16       16              
  Lines        5988     6016      +28     
==========================================
+ Hits         5245     5273      +28     
  Misses        743      743

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jswrenn jswrenn force-pushed the io branch 2 times, most recently from e4949fb to 6367580 Compare November 5, 2024 16:22
@jswrenn jswrenn marked this pull request as ready for review November 5, 2024 16:23
@jswrenn jswrenn requested a review from joshlf November 5, 2024 16:23
joshlf
joshlf requested changes Nov 5, 2024
View reviewed changes
@jswrenn @joshlf
Add FromBytes::read_from_io and IntoBytes::write_to_io
c38fc1f 
Makes progress on #158.

Co-authored-by: Joshua Liebow-Feeser <joshlf@users.noreply.github.com>
@jswrenn jswrenn enabled auto-merge November 7, 2024 22:19
@jswrenn jswrenn requested a review from joshlf November 7, 2024 22:19
@jswrenn jswrenn added this pull request to the merge queue Nov 8, 2024
Merged via the queue into v0.8.x with commit e3b2ec1 Nov 8, 2024
@jswrenn jswrenn deleted the io branch November 8, 2024 22:31
joshlf added a commit that referenced this pull request Nov 11, 2024
@jswrenn @joshlf
Add FromBytes::read_from_io and IntoBytes::write_to_io (#2016)
01f0288 
Makes progress on #158.

Co-authored-by: Joshua Liebow-Feeser <joshlf@users.noreply.github.com>
gherrit-pr-id: I9253d6be7407d8d8679ee355e4e71cd9b15b9ff7
@joshlf
Copy link
Member

joshlf commented Nov 11, 2024

Backporting in #2046

@joshlf joshlf mentioned this pull request Nov 11, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 12, 2024
@joshlf @jswrenn
Add FromBytes::read_from_io and IntoBytes::write_to_io (#2016) (#…
6c2a249 
…2046)

Makes progress on #158.


gherrit-pr-id: I9253d6be7407d8d8679ee355e4e71cd9b15b9ff7

Co-authored-by: Jack Wrenn <jswrenn@amazon.com>
@joshlf joshlf mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshlf joshlf joshlf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jswrenn @codecov-commenter @joshlf