Skip to content

[CI] Optimize (and fix) caching#106

Merged
joshlf merged 1 commit intogoogle:mainfrom
glokta1:optimize-caching
Oct 27, 2022
Merged

[CI] Optimize (and fix) caching#106
joshlf merged 1 commit intogoogle:mainfrom
glokta1:optimize-caching

Conversation

@glokta1
Copy link
Contributor

@glokta1 glokta1 commented Oct 27, 2022

Resolves #85

- Remove redundant flags in `key` when using rust-cache. They are
  automatically added by the action.
- Add 'push to main' as trigger to reuse cache across PRs. See https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows\#restrictions-for-accessing-a-cache

Resolves google#85
Copy link
Member

@joshlf joshlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @glokta1!

@joshlf
Copy link
Member

joshlf commented Oct 27, 2022

I'm getting an error when trying to merge that might be related to the contents of this PR. I've had issues on mobile before, so it also might just be that. I'll try again later through the web UI and see if that works.

image

@joshlf joshlf merged commit 79dcfd2 into google:main Oct 27, 2022
@glokta1 glokta1 deleted the optimize-caching branch October 27, 2022 15:40
@glokta1
Copy link
Contributor Author

glokta1 commented Oct 28, 2022

@joshlf Hey, can I ask you to please add the 'Hacktoberfest-Accepted' label? Thanks!

@joshlf
Copy link
Member

joshlf commented Oct 28, 2022

Done!

joshlf pushed a commit that referenced this pull request Aug 3, 2023
- Remove redundant flags in `key` when using rust-cache. They are
  automatically added by the action.
- Add 'push to main' as trigger to reuse cache across PRs. See https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows\#restrictions-for-accessing-a-cache

Resolves #85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize caching in CI

2 participants