-
Notifications
You must be signed in to change notification settings - Fork 142
Closed
Labels
experience-mediumThis issue is of medium difficulty, and requires some experienceThis issue is of medium difficulty, and requires some experiencegood first issueGood for newcomersGood for newcomers
Description
In CI, we use the Swatinem/rust-cache GitHub Action to cache certain build artifacts across runs. However, it seems from the README that we might be using it in a suboptimal way. A few observations:
- Zerocopy has only one dependency, and
rust-cacheonly caches dependencies, not crate artifacts (note that zerocopy-derive has more dependencies - and dependencies that are expensive to compile - so presumably benefits much more than zerocopy) - We generate a custom cache key which includes:
- A hash of the Cargo features, but this presumably shouldn't have any effect on dependencies (at least in our case, since none of our Cargo features depend on dependencies' Cargo features)
- A hash of
**/Cargo.lock, but this is documented to be the default behavior anyway
We should:
- Figure out if there's a way to squeeze more benefit out for zerocopy (can we get
rust-cacheto cache any more artifacts?) - Don't include Cargo features in the cache
- Don't include a hash of
**/Cargo.lockin the cache - Go back over our use of
rust-cacheand its README with a fine toothed comb and see what else we're doing suboptimally
cc @Swatinem in case there's anything obvious that jumps out at you!
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
experience-mediumThis issue is of medium difficulty, and requires some experienceThis issue is of medium difficulty, and requires some experiencegood first issueGood for newcomersGood for newcomers