-
Notifications
You must be signed in to change notification settings - Fork 338
Closed
Labels
P1Medium priorityMedium priorityTeam MIssues for Squad 2Issues for Squad 2Type: BugSomething isn't workingSomething isn't workingType: SupportSupport requestSupport request
Description
Bug Description
As reported by one user in the Site Kit support forums, a depreciation notice exists, possibly from the admin toolbar. The error appears as below:
PHP Deprecated: Calling get_class() without arguments is deprecated in /.../google-site-kit/third-party/google/apiclient/src/Http/REST.php on line 49
Awaiting Site Health information from impacted user.
Note that this error was highlighted by engineering when reviewing another issue (#8589). Maybe you have some insights into this @mohitwp?
Additional Context
- PHP Version:
- OS: [e.g. iOS]
- Browser: [e.g. chrome, safari]
- Plugin Version: [e.g. 22]
- Device: [e.g. iPhone6]
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
google/apiclientshould be upgraded to2.15.2or higher
Implementation Brief
- Upgrade the dependency once Upgrade to Guzzle v7 #10302 is merged
- Finish and merge Upgrade apiclient #10402
- Ensure all PHP Scoper config customization is still valid as noted in
PHP Deprecated: Calling get_class() without arguments is deprecated in google-site-kit/third-party/google/apiclient/...#9977 (comment)
- Ensure all PHP Scoper config customization is still valid as noted in
Test Coverage
- No changes
QA Brief
- This change updates the Google PHP packages for accessing Google APIs and using OAuth 2. Authentication and API requests to various Google services should still function.
- Perform a smoke test of the core reports on the dashboard for various Site Kit modules (Search Console, Analytics, etc.) and test across different supported PHP and WordPress versions.
Changelog entry
- Upgrade Google API client library to avoid deprecation notices on latest versions of PHP.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P1Medium priorityMedium priorityTeam MIssues for Squad 2Issues for Squad 2Type: BugSomething isn't workingSomething isn't workingType: SupportSupport requestSupport request