-
Notifications
You must be signed in to change notification settings - Fork 338
Closed
Labels
P1Medium priorityMedium priorityPHPQA: EngRequires specialized QA by an engineerRequires specialized QA by an engineerTeam SIssues for Squad 1Issues for Squad 1Type: InfrastructureEngineering infrastructure & toolingEngineering infrastructure & tooling
Description
Feature Description
Guzzle is one of Site Kit's core dependencies as the HTTP client used by google/apiclient.
Now that Site Kit's minimum PHP version requirement is 7.4, we're no longer blocked from upgrading to Guzzle 7 and even able to use the latest stable version: 7.9.2!
This should be smoother than the upgrade from Guzzle 5 -> 6 (done in #1146), and is important to unblock upgrades of other dependencies.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
guzzlehttp/guzzleshould be upgraded to the latest v7 version- All existing Guzzle client customizations must continue to work (see
Client_Factory::create_client)
- All existing Guzzle client customizations must continue to work (see
Implementation Brief
- Update
guzzlehttp/guzzleto the7.9.2- Updating this library will fail due to it's dependency
guzzlehttp/psr7which needs to be2.7.0. It is locked to the google api library which is locaked at1.9.1. So it should be updated together with it's dependencies - So far it doesn't seem to break anything, I did a quick exploration and dashboard data is working correctly with no notice/error in the error log. The only thing needing some updates is tests. They fail for same reason, the middleware expects promise as return, but in our fakehttp handler we return
new Response, so it will take updating this in all tests that returnnew Responseto return a wrapper around responsenew FulfilledPromise( new Response(...)) - There is a quick PoC branch that can be checked for example
- Updating this library will fail due to it's dependency
- Do an ad-hoc test if everything is working as expected
Test Coverage
- Fix failing tests
QA Brief
- This update updates the package that makes all requests to the Google API. All requests for reports from various Google services should still function.
- Perform a smoke test of the core reports on the dashboard for various Site Kit modules (Search Console, Analytics, etc.) and test across different supported PHP and WordPress versions.
Changelog entry
- Update Guzzle to v7.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P1Medium priorityMedium priorityPHPQA: EngRequires specialized QA by an engineerRequires specialized QA by an engineerTeam SIssues for Squad 1Issues for Squad 1Type: InfrastructureEngineering infrastructure & toolingEngineering infrastructure & tooling