Skip to content

Upgrade apiclient#10402

Merged
aaemnnosttv merged 6 commits intodevelopfrom
upgrade/9977-apiclient
Mar 14, 2025
Merged

Upgrade apiclient#10402
aaemnnosttv merged 6 commits intodevelopfrom
upgrade/9977-apiclient

Conversation

@aaemnnosttv
Copy link
Copy Markdown
Collaborator

@aaemnnosttv aaemnnosttv commented Mar 10, 2025 •
edited by techanvil
Loading

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@aaemnnosttv aaemnnosttv mentioned this pull request Mar 10, 2025
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 10, 2025 •
edited
Loading

Build files for 7c74e6e have been deleted.

techanvil
techanvil reviewed Mar 13, 2025
View reviewed changes
scoper.inc.php
// Avoid prefixing the `static` keyword in some places.
$contents = str_replace( "\\$prefix\\static", 'static', $contents );

if ( preg_match( '#google/apiclient/src/Google/Http/REST\.php$#', $file_path ) ) {
Copy link
Copy Markdown
Collaborator

@techanvil techanvil Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed some of the rules are no longer needed, so tidied them up a bit.

aaemnnosttv
aaemnnosttv commented Mar 14, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator Author

@aaemnnosttv aaemnnosttv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @techanvil – this LGTM however I can't approve it since it's originally my own PR 😆 Would you give it the ✅ if you agree?

techanvil
techanvil approved these changes Mar 14, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@techanvil techanvil left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem Evan, will do.

Proxying @aaemnnosttv's approval for this PR. LGTM!

✅

Note, the failing E2E tests are unrelated to these changes.

@aaemnnosttv aaemnnosttv merged commit 0b25a94 into develop Mar 14, 2025
22 of 23 checks passed
@aaemnnosttv aaemnnosttv deleted the upgrade/9977-apiclient branch March 14, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@techanvil techanvil techanvil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aaemnnosttv @techanvil