Travis: download and install pip on macOS#461
Travis: download and install pip on macOS#461antiagainst wants to merge 1 commit intogoogle:masterfrom
Conversation
20f6828 to
c3fbeda
Compare
dneto0
left a comment
There was a problem hiding this comment.
The code change does not match the commit description.
e9505d1 to
244711b
Compare
| install: | ||
| - if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then | ||
| sudo easy_install pip; | ||
| curl https://bootstrap.pypa.io/get-pip.py -o /tmp/get-pip.py; |
There was a problem hiding this comment.
Do we know that /tmp from different jobs are isolated so that this will never collide?
It would be better if there were a TMP environment variable provided by Travis, but it seems not:
https://docs.travis-ci.com/user/environment-variables/#Default-Environment-Variables
I would rather get that file in the current directory:
curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py;
sudo python get-pip.py;
rm -f get-pip.py
I presume that the current directory is : always isolated from other builds, and writable.
Or
There was a problem hiding this comment.
We are requiring sudo. IIRC, for sudo environments, we get full VM: https://docs.travis-ci.com/user/reference/overview/#Virtualisation-Environment-vs-Operating-System
So /tmp should be isolated.
I tried to use the current directory for the project, then add_copyright.py checks yelled at me because get-pip.py does not have a copyright header. :(
dneto0
left a comment
There was a problem hiding this comment.
Thanks for the followup and experience report. That's a good answer.
|
Rebased and pushed into master as be8e087 |
…8ebe e7294a8ebe Add headers for SPV_NV_linear_swept_spheres. (google#483) 003bcf4e0d Add headers for SPV_NV_cluster_acceleration_structure. (google#484) 43764cc756 updates IntegerFunctions2INTEL to remove Shader capability dependency (google#481) 767e901c98 Add SPV_NV_cooperative_vector (google#482) 2b2e05e088 grammar and header changes for SPV_INTEL_subgroup_matrix_multiply_accumulate (google#471) 0659679d96 Add a source language for Rust (google#472) 9ca0e67b5e grammar and header changes for SPV_INTEL_2d_block_io (google#470) a380cd2543 Fix OpAsmTargetINTEL operand (google#468) 3f17b2af67 [SPIRV] Add generator magic number (google#467) 36d5e2ddaa Add provisional key to grammar (google#464) 45b314049d Add NonSemanticShaderDebugInfo100.h to bazel build. (google#466) 2ce05a6f79 Remove trailing whitespace (google#465) 996c728cf7 add basic utility code testing for cpp, cpp11, and c (google#461) cb6b2c32db Fix on header generator for c++11, regenerated products (google#463) 22c4d1b1e9 Add SPV_NV_cooperative_matrix2 and SPV_NV_tensor_addressing (google#458) 252dc2df08 Add nuvk's spirv emitter. (google#454) 50bc4debdc VkspReflection non-sematic: remove literals for Ids (google#453) 07ddb1c0f1 Update SPV_AMDX_shader_enqueue (google#452) d92cf88c37 Add "aliases" fields to the grammar and remove duplicated (google#447) a62b032007 Add SPV_EXT_arithmetic_fence (google#450) ec59c77a3b Reserve SPIR-V enums for MediaTek (google#451) 0413bc33fa Add SPV_EXT_optnone (google#449) git-subtree-dir: third_party/spirv-headers git-subtree-split: e7294a8ebed84f8c5bd3686c68dbe12a4e65b644
No description provided.