Force binary mode when writing a binary to stdout#458
Merged
antiagainst merged 1 commit intogoogle:masterfrom May 11, 2018
Merged
Force binary mode when writing a binary to stdout#458antiagainst merged 1 commit intogoogle:masterfrom
antiagainst merged 1 commit intogoogle:masterfrom
Conversation
antiagainst
approved these changes
May 9, 2018
Contributor
antiagainst
left a comment
There was a problem hiding this comment.
LGTM. But glslang tests are failing. Not sure why.
Collaborator
Author
|
I can reproduce the failure on Windows. Oddly, I haven't yet reproduced the failure on Linux. |
For the test: also refactor the glslc test expectation code to be able to check the length and header of a binary residing in a Python "bytes" object, not just in a file. Fixes google#457
Collaborator
Author
|
Rebased. Will watch the bots. I expect only the pip issue on OSX |
Contributor
|
Only pip issue remaining. I'll merge this. |
stenzek
added a commit
to stenzek/shaderc
that referenced
this pull request
Feb 2, 2025
…8ebe e7294a8ebe Add headers for SPV_NV_linear_swept_spheres. (google#483) 003bcf4e0d Add headers for SPV_NV_cluster_acceleration_structure. (google#484) 43764cc756 updates IntegerFunctions2INTEL to remove Shader capability dependency (google#481) 767e901c98 Add SPV_NV_cooperative_vector (google#482) 2b2e05e088 grammar and header changes for SPV_INTEL_subgroup_matrix_multiply_accumulate (google#471) 0659679d96 Add a source language for Rust (google#472) 9ca0e67b5e grammar and header changes for SPV_INTEL_2d_block_io (google#470) a380cd2543 Fix OpAsmTargetINTEL operand (google#468) 3f17b2af67 [SPIRV] Add generator magic number (google#467) 36d5e2ddaa Add provisional key to grammar (google#464) 45b314049d Add NonSemanticShaderDebugInfo100.h to bazel build. (google#466) 2ce05a6f79 Remove trailing whitespace (google#465) 996c728cf7 add basic utility code testing for cpp, cpp11, and c (google#461) cb6b2c32db Fix on header generator for c++11, regenerated products (google#463) 22c4d1b1e9 Add SPV_NV_cooperative_matrix2 and SPV_NV_tensor_addressing (google#458) 252dc2df08 Add nuvk's spirv emitter. (google#454) 50bc4debdc VkspReflection non-sematic: remove literals for Ids (google#453) 07ddb1c0f1 Update SPV_AMDX_shader_enqueue (google#452) d92cf88c37 Add "aliases" fields to the grammar and remove duplicated (google#447) a62b032007 Add SPV_EXT_arithmetic_fence (google#450) ec59c77a3b Reserve SPIR-V enums for MediaTek (google#451) 0413bc33fa Add SPV_EXT_optnone (google#449) git-subtree-dir: third_party/spirv-headers git-subtree-split: e7294a8ebed84f8c5bd3686c68dbe12a4e65b644
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the test: also refactor the glslc test expectation code to
be able to check the length and header of a binary residing in a
Python "bytes" object, not just in a file.
Fixes #457