Issue 2135: Change template args in NiceMock, NaggyMock and StrictMock from A1, A2, ... to TArg1, TArg2,... to avoid clash with legacy header files#3042
Merged
derekmauro merged 1 commit intogoogle:masterfrom Oct 15, 2020
Conversation
…k from A1, A2, ... to TArg1, TArg2,... to avoid clash with legacy header files
This was referenced Oct 7, 2020
toto199
approved these changes
Oct 8, 2020
Contributor
Author
|
Hi there, does anyone have any advice on how to resolve the failing appveyor build on "Environment: compiler=msvc-15-seh, build_system=bazel, APPVEYOR_BUILD_WORKER_IMAGE=Visual Studio 2017, enabled_on_pr=yes"? It does not seem related?: |
|
Please reomve me from your mail list
…On Tue, Oct 13, 2020 at 3:07 AM Aralox ***@***.***> wrote:
Hi there, does anyone have any advice on how to resolve the failing
appveyor build on "Environment: compiler=msvc-15-seh, build_system=bazel,
APPVEYOR_BUILD_WORKER_IMAGE=Visual Studio 2017, enabled_on_pr=yes"?
It does not seem related?:
ERROR:
C:/users/appveyor/_bazel_appveyor/dwud7wpd/external/rules_cc/cc/private/rules_impl/cc_flags_supplier.bzl:28:21:
unexpected keyword 'incompatible_use_toolchain_transition'
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3042 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO7RFJVJPLGYNDELOUJV72DSKNZK3ANCNFSM4SHAKX4Q>
.
|
derekmauro
added a commit
that referenced
this pull request
Oct 15, 2020
…args-AX-to-TArgX PiperOrigin-RevId: 337217118
Contributor
Author
|
Hi @derekmauro , could you please add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2154
Done as part of hacktoberfest! :)