Skip to content

Replaced template arguments A0, A10 with TArg0..10#2154

Closed
Aralox wants to merge 2 commits intogoogle:masterfrom
Aralox:feature/rename-type-args
Closed

Replaced template arguments A0, A10 with TArg0..10#2154
Aralox wants to merge 2 commits intogoogle:masterfrom
Aralox:feature/rename-type-args

Conversation

@Aralox
Copy link
Copy Markdown
Contributor

@Aralox Aralox commented Feb 26, 2019

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@gennadiycivil
Copy link
Copy Markdown
Contributor

No CLA

@Aralox
Copy link
Copy Markdown
Contributor Author

Aralox commented Mar 4, 2019

Still working on it, I'll let you know when I've sorted it out with my company. Thanks

@googlebot
Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@gennadiycivil
Copy link
Copy Markdown
Contributor

@Aralox just to let you know, we had an internal discussion and yes we would be OK with this change because it would be useful for your work.
Just please make sure to change the .pump files and re-gen, dont change this directly. And work out the CLA of course
thanks again

@PravinPrameKumar
Copy link
Copy Markdown

Thank you, I'm glad to hear that :). I've changed gmock-generated-actions.h.pump and regenerated the header file. CLA still in progress, I'll message back when its good to go.

@gennadiycivil
Copy link
Copy Markdown
Contributor

Ping

@PravinPrameKumar
Copy link
Copy Markdown

PravinPrameKumar commented Apr 1, 2019

Still in progress! ☺️
EDIT May 10: Still in progress :)

@gennadiycivil
Copy link
Copy Markdown
Contributor

I will close this for now, please come back when ready

@PravinPrameKumar
Copy link
Copy Markdown

Sure, no worries, will do.

@Aralox
Copy link
Copy Markdown
Contributor Author

Aralox commented Oct 7, 2020

Hi @gennadiycivil, I've decided to re-do this PR for hacktoberfest :) (https://hacktoberfest.digitalocean.com/hacktoberfest-update)
I've submitted it under my own name this time, and have accepted the CLA.
My changes are much simpler this time, they only involve gmock-nice-strict.h, because of the wonderful work done last year to use variadic templates in gmock-generated-actions.h.

@Aralox
Copy link
Copy Markdown
Contributor Author

Aralox commented Oct 7, 2020

Reopened as #3042
(much simpler)

Copy link
Copy Markdown

@toto199 toto199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants