Replaced template arguments A0, A10 with TArg0..10#2154
Replaced template arguments A0, A10 with TArg0..10#2154Aralox wants to merge 2 commits intogoogle:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
No CLA |
|
Still working on it, I'll let you know when I've sorted it out with my company. Thanks |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
@Aralox just to let you know, we had an internal discussion and yes we would be OK with this change because it would be useful for your work. |
|
Thank you, I'm glad to hear that :). I've changed gmock-generated-actions.h.pump and regenerated the header file. CLA still in progress, I'll message back when its good to go. |
|
Ping |
|
Still in progress! |
|
I will close this for now, please come back when ready |
|
Sure, no worries, will do. |
|
Hi @gennadiycivil, I've decided to re-do this PR for hacktoberfest :) (https://hacktoberfest.digitalocean.com/hacktoberfest-update) |
|
Reopened as #3042 |
#2135