[Swift] Improves the performance creating strings #8772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the performance of the implementation in Swift by using withCString instead of the contigiousString
aardappel
approved these changes
Nov 14, 2025
TJKoury
pushed a commit
to DigitalArsenal/flatbuffers
that referenced
this pull request
Nov 19, 2025
Improves the performance of the implementation in Swift by using withCString instead of the contigiousString
TJKoury
pushed a commit
to DigitalArsenal/flatbuffers
that referenced
this pull request
Nov 19, 2025
Improves the performance of the implementation in Swift by using withCString instead of the contigiousString
dongjoon-hyun
added a commit
to apache/spark-connect-swift
that referenced
this pull request
Jan 5, 2026
### What changes were proposed in this pull request? This PR aims to upgrade `FlatBuffers` to `v25.12.19` ### Why are the changes needed? To bring the latest bug fixes and improvements - https://github.com/google/flatbuffers/releases/tag/v25.12.19 (2025-12-19) - google/flatbuffers#8758 - google/flatbuffers#8772 - google/flatbuffers#8755 - google/flatbuffers#8815 - google/flatbuffers#8752 - google/flatbuffers#8742 ### Does this PR introduce _any_ user-facing change? No. There is no behavior change. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Yes (`Gemini 3 Pro` on `Antigravity`) Closes #275 from dongjoon-hyun/SPARK-54899. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the performance of the implementation in Swift by using
withCStringinstead of thewithContiguousStorageIfAvailable. We already use thewithCStringin the FlexBuffers implementation. So adding it to FlatBuffers was a no-brainer.