-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[Swift] Inline arrays #8755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[Swift] Inline arrays #8755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7da7cf5 to
3fd4d16
Compare
3fd4d16 to
e09d90c
Compare
Implements inlinearrays which allow us to use Flatbuffers arrays within Structs natively, and also implements FlatbufferVectors as a secondary API when using mutable Structs Fixes mutations within fixed sizes arrays Adds tests and remove inout and mutating from generated objects in favor of borrowing
e09d90c to
a4039e0
Compare
aardappel
approved these changes
Nov 14, 2025
TJKoury
pushed a commit
to DigitalArsenal/flatbuffers
that referenced
this pull request
Nov 19, 2025
Implements InlineArrays which allow us to use Flatbuffers arrays within Structs natively, and also implements FlatbufferVectors as a secondary API when using mutable Structs Fixes mutations within fixed sizes arrays Adds tests and remove inout and mutating from generated objects in favor of borrowing --------- Co-authored-by: Wouter van Oortmerssen <aardappel@gmail.com>
TJKoury
pushed a commit
to DigitalArsenal/flatbuffers
that referenced
this pull request
Nov 19, 2025
Implements InlineArrays which allow us to use Flatbuffers arrays within Structs natively, and also implements FlatbufferVectors as a secondary API when using mutable Structs Fixes mutations within fixed sizes arrays Adds tests and remove inout and mutating from generated objects in favor of borrowing --------- Co-authored-by: Wouter van Oortmerssen <aardappel@gmail.com>
dongjoon-hyun
added a commit
to apache/spark-connect-swift
that referenced
this pull request
Jan 5, 2026
### What changes were proposed in this pull request? This PR aims to upgrade `FlatBuffers` to `v25.12.19` ### Why are the changes needed? To bring the latest bug fixes and improvements - https://github.com/google/flatbuffers/releases/tag/v25.12.19 (2025-12-19) - google/flatbuffers#8758 - google/flatbuffers#8772 - google/flatbuffers#8755 - google/flatbuffers#8815 - google/flatbuffers#8752 - google/flatbuffers#8742 ### Does this PR introduce _any_ user-facing change? No. There is no behavior change. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Yes (`Gemini 3 Pro` on `Antigravity`) Closes #275 from dongjoon-hyun/SPARK-54899. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements InlineArrays which allow us to use FlatBuffers arrays within
Structs natively, and also implements FlatbufferVectors as a secondary API
when using mutable Structs
depends on: #8758