Skip to content

Conversation

@mustiikhalil
Copy link
Collaborator

@mustiikhalil mustiikhalil commented Nov 4, 2025

Implements InlineArrays which allow us to use FlatBuffers arrays within
Structs natively, and also implements FlatbufferVectors as a secondary API
when using mutable Structs

depends on: #8758

@github-actions github-actions bot added c++ codegen Involving generating code from schema grpc python swift labels Nov 4, 2025
@github-actions github-actions bot added the CI Continuous Integration label Nov 4, 2025
@github-actions github-actions bot removed the CI Continuous Integration label Nov 4, 2025
@github-actions github-actions bot removed the grpc label Nov 5, 2025
Implements inlinearrays which allow us to use Flatbuffers arrays within
Structs natively, and also implements FlatbufferVectors as a secondary API
when using mutable Structs

Fixes mutations within fixed sizes arrays

Adds tests and remove inout and mutating from generated objects in favor of borrowing
@github-actions github-actions bot added CI Continuous Integration grpc labels Nov 5, 2025
@mustiikhalil mustiikhalil marked this pull request as ready for review November 5, 2025 22:24
@mustiikhalil mustiikhalil self-assigned this Nov 5, 2025
@mustiikhalil mustiikhalil marked this pull request as draft November 11, 2025 07:30
@github-actions github-actions bot removed grpc CI Continuous Integration labels Nov 14, 2025
@mustiikhalil mustiikhalil marked this pull request as ready for review November 14, 2025 23:10
@mustiikhalil mustiikhalil merged commit cbf0850 into google:master Nov 14, 2025
50 checks passed
@mustiikhalil mustiikhalil deleted the mmk/inline-array branch November 14, 2025 23:33
TJKoury pushed a commit to DigitalArsenal/flatbuffers that referenced this pull request Nov 19, 2025
Implements InlineArrays which allow us to use Flatbuffers arrays within
Structs natively, and also implements FlatbufferVectors as a secondary API
when using mutable Structs

Fixes mutations within fixed sizes arrays

Adds tests and remove inout and mutating from generated objects in favor of borrowing

---------

Co-authored-by: Wouter van Oortmerssen <aardappel@gmail.com>
TJKoury pushed a commit to DigitalArsenal/flatbuffers that referenced this pull request Nov 19, 2025
Implements InlineArrays which allow us to use Flatbuffers arrays within
Structs natively, and also implements FlatbufferVectors as a secondary API
when using mutable Structs

Fixes mutations within fixed sizes arrays

Adds tests and remove inout and mutating from generated objects in favor of borrowing

---------

Co-authored-by: Wouter van Oortmerssen <aardappel@gmail.com>
dongjoon-hyun added a commit to apache/spark-connect-swift that referenced this pull request Jan 5, 2026
### What changes were proposed in this pull request?

This PR aims to upgrade `FlatBuffers` to `v25.12.19`

### Why are the changes needed?

To bring the latest bug fixes and improvements
- https://github.com/google/flatbuffers/releases/tag/v25.12.19 (2025-12-19)
  - google/flatbuffers#8758
  - google/flatbuffers#8772
  - google/flatbuffers#8755
  - google/flatbuffers#8815
  - google/flatbuffers#8752
  - google/flatbuffers#8742

### Does this PR introduce _any_ user-facing change?

No. There is no behavior change.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

Yes (`Gemini 3 Pro` on `Antigravity`)

Closes #275 from dongjoon-hyun/SPARK-54899.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ codegen Involving generating code from schema python swift

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants