avoiding even more NoSuchMethod exceptions #6729
Conversation
|
@aardappel do you know why Kotlin doesn't see the symbol? |
|
Sigh, third time's a charm? @paulovap might know. |
I think there must be added a unit test for this(if it is not already covered) and run on different java versions. Now we run our tests against Java 1.8. Maybe create a action with minimum java version( 7? 8?) and another with java 11 or 14. Just to make sure we keep it working on the old and new versions. |
|
As far as I understand the issue, the problem can be replicated simply by using the published package with java 8, so it seems easy to automate. |
|
So what is happening with Kotlin? What needs to happen to merge this? |
This can be merged. Kotlin uses the java runtime still, so nothing needs to be done for Kotlin. |
With the changes introduced on google#6729, google#6671, google#6658 it seems that using java compiler version 8 is no longer possible. We are adjusting our CI build for Kotlin to use Java 11 as compiler, while still emiting 1.8 bytecode. The Kotlin CI action is also being breakdown into two: Mac & Linux. Kotlin mac will test ios & mac builds while Linux will test js and JVM. This change will improve build times for Kotlin on CI, which is currently taking long times.
With the changes introduced on #6729, #6671, #6658 it seems that using java compiler version 8 is no longer possible. We are adjusting our CI build for Kotlin to use Java 11 as compiler, while still emiting 1.8 bytecode. The Kotlin CI action is also being breakdown into two: Mac & Linux. Kotlin mac will test ios & mac builds while Linux will test js and JVM. This change will improve build times for Kotlin on CI, which is currently taking long times.
This reverts commit 6fb2c90.
* Revert "avoiding even more NoSuchMethod exceptions (#6729)" This reverts commit 6fb2c90. * Revert "avoiding more NoSuchMethod exceptions (#6671)" This reverts commit 752c7b5. * Revert "avoiding NoSuchMethod exception (#6658)" This reverts commit 813d363. * Use Java 8 for Kotlin Linux builds to verify
Unfortunately, missed some :(