[Java] Avoid casting ByteBuffer to Buffer #6785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@bjornharrtell can you also change https://github.com/google/flatbuffers/blob/master/.github/workflows/build.yml#L146 to use java 8 so we can make sure it compiles properly? We can keep one build using java 8 and another using java 11 to guarantee both compilers works properly. |
Contributor
|
Maybe we can release a new version after we make sure everything works now. |
Collaborator
Author
|
@paulovap agreed and done. |
Collaborator
Author
|
@aardappel this is ready to merge and should hopefully resolve the issues you had in publishing a java patch version |
Collaborator
|
Thanks! The long winded story of Java incompatibilities is coming full circle :) |
Collaborator
|
Ok, a maven release of 2.0.3 completed succesfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it causes flatbuffers to be incompatible with Java 8 and it was the wrong course of action to take for the original issue.